Bug 118427

Summary:

[GTK] Add support for running unit tests in the web process

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, gustavo, mrobinson, philn, sam, xan.lopez, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

118426, 118430, 118431

Attachments:

Description	Flags
Patch	none
Updated patch	gustavo: review+

Carlos Garcia Campos

Reported 2013-07-05 10:38:33 PDT

Some tests, like GObject DOM bindings API tests run entirely in the WebProcess, we could mke it easy to create these kind of tests. It could also be used to ATK tests.The idea is that the UI process test is just a proxy to run the tests in the web process using a web process extension.

Attachments
Patch (28.45 KB, patch) 2013-07-05 11:00 PDT, Carlos Garcia Campos	no flags	Details Formatted Diff Diff
Updated patch (31.45 KB, patch) 2013-07-05 12:31 PDT, Carlos Garcia Campos	gustavo: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2013-07-05 11:00:25 PDT

Created attachment 206163 [details] Patch It also includes the migration of the WebKitDOMNode test as a first example. We can migrate all others in follow up patches.

WebKit Commit Bot

Comment 2 2013-07-05 11:03:18 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Carlos Garcia Campos

Comment 3 2013-07-05 12:31:48 PDT

Created attachment 206166 [details] Updated patch I forgot to git add a file

Sam Weinig

Comment 4 2013-07-05 21:27:31 PDT

Can this go into Tools/?

Carlos Garcia Campos

Comment 5 2013-07-07 23:33:23 PDT

(In reply to comment #4) > Can this go into Tools/? We have our WebKit2 GTK+ API unit tests in UIProcess/API/gtk/tests it can perfectly be moved to Tools, but not this patch independently, we would need to move the tests directory. Qt and EFL both also have their tests in UIProcess/API/port/tests, though. Maybe we could reorganize the tests moving everything into Tools/TestWebKitAPI having subdirs for every API: C, efl, qt, gtk, etc.

Gustavo Noronha (kov)

Comment 6 2013-07-25 06:04:19 PDT

Comment on attachment 206166 [details] Updated patch OK, I'm fine with moving the tests under Tools, fwiw, we can do that in a separate patch.

Carlos Garcia Campos

Comment 7 2013-07-25 09:12:26 PDT

Committed r153327: <http://trac.webkit.org/changeset/153327>

Note You need to log in before you can comment on or make changes to this bug.