Summary: | [GTK] Add support for running unit tests in the web process | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, gustavo, mrobinson, philn, sam, xan.lopez, zan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 118426, 118430, 118431 | ||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2013-07-05 10:38:33 PDT
Created attachment 206163 [details]
Patch
It also includes the migration of the WebKitDOMNode test as a first example. We can migrate all others in follow up patches.
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Created attachment 206166 [details]
Updated patch
I forgot to git add a file
Can this go into Tools/? (In reply to comment #4) > Can this go into Tools/? We have our WebKit2 GTK+ API unit tests in UIProcess/API/gtk/tests it can perfectly be moved to Tools, but not this patch independently, we would need to move the tests directory. Qt and EFL both also have their tests in UIProcess/API/port/tests, though. Maybe we could reorganize the tests moving everything into Tools/TestWebKitAPI having subdirs for every API: C, efl, qt, gtk, etc. Comment on attachment 206166 [details]
Updated patch
OK, I'm fine with moving the tests under Tools, fwiw, we can do that in a separate patch.
Committed r153327: <http://trac.webkit.org/changeset/153327> |