Bug 118399

Summary:

Add a method to get unreachable URL from WebFrame.

Product:

WebKit

Reporter:

Yongjun Zhang <yongjun_zhang>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ddkilzer, mitz, yongjun_zhang

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.8

Attachments:

Description	Flags
add a method to expose unreachableURL for WebFrame.	none

Yongjun Zhang

Reported 2013-07-04 11:53:40 PDT

Normally we could use [[WebFrame dataSource] unreachableURL] to get the failed URL. However, if the frame has not loaded (FrameLoader::frameHasLoaded() is false), we will get a nil dataSource and we won't be able to get unreachableURL. We need to add a method to always return the unreachableURL regardless if the frame has loaded or not.

Attachments
add a method to expose unreachableURL for WebFrame. (2.04 KB, patch) 2013-07-04 12:00 PDT, Yongjun Zhang	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yongjun Zhang

Comment 1 2013-07-04 12:00:27 PDT

Created attachment 206107 [details] add a method to expose unreachableURL for WebFrame.

Yongjun Zhang

Comment 2 2013-07-04 12:17:58 PDT

thanks mitz!

WebKit Commit Bot

Comment 3 2013-07-04 12:54:05 PDT

Comment on attachment 206107 [details] add a method to expose unreachableURL for WebFrame. Clearing flags on attachment: 206107 Committed r152405: <http://trac.webkit.org/changeset/152405>

WebKit Commit Bot

Comment 4 2013-07-04 12:54:07 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.