Bug 118391

Summary: Remove support for [PassThisToCallback] extended attribute
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, darin, esprehn+autocc, haraken, laszlo.gombos, rniwa, thorton, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 none

Description Chris Dumez 2013-07-04 05:48:50 PDT 
The [PassThisToCallback] Webkit-specific IDL extended attribute is supported by the JSC bindings generator but is no longer used. We can therefore drop support for this from the generator to simplify the code.
Comment 1 Chris Dumez 2013-07-04 05:53:34 PDT 
Created attachment 206081 [details]
Patch
Comment 2 Kentaro Hara 2013-07-04 05:54:55 PDT 
Comment on attachment 206081 [details]
Patch

Looks OK.
Comment 3 Build Bot 2013-07-04 09:51:07 PDT 
Comment on attachment 206081 [details]
Patch

Attachment 206081 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1026325

New failing tests:
http/tests/security/cross-origin-plugin-private-browsing-toggled.html
Comment 4 Build Bot 2013-07-04 09:51:09 PDT 
Created attachment 206099 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 5 WebKit Commit Bot 2013-07-09 03:56:50 PDT 
Comment on attachment 206081 [details]
Patch

Clearing flags on attachment: 206081

Committed r152490: <http://trac.webkit.org/changeset/152490>
Comment 6 WebKit Commit Bot 2013-07-09 03:56:53 PDT 
All reviewed patches have been landed.  Closing bug.