Bug 118390
| Summary: | [EFL] Ews doesn't build correctly when RaisesException in the idl is removed | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kihong Kwon <kihong.kwon> |
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | lucas.de.marchi, mcatanzaro, rakuco |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Other | ||
| OS: | Linux | ||
Kihong Kwon
Ews doesn't build correctly when RaisesException in the idl is removed.
For example,
Remove RaisesException from registerProtocolHandler in the NavigatorContentUtil.idl.
And remove Exceptioncode& from registerProtocolHandler in the NavigatorContentUtil.h/cpp.
In this case, ews makes below build error.
WebKitBuild/Debug/DerivedSources/WebCore/JSNavigator.cpp:506:80: error: no matching function for call to ‘WebCore::NavigatorContentUtils::registerProtocolHandler(WebCore::Navigator*&, const WTF::String&, const WTF::String&, const WTF::String&, WebCore::ExceptionCode&)’
But, It has to be build successfully without any error message.
In this case, JSNavigator has to be generated newly.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Raphael Kubo da Costa (:rakuco)
Are you able to reproduce the issue locally? I tried doing what you said on my machine (at r152410) and then running build-webkit. All DerivedSources for WebCore were regenerated and mostly all files in WebCore were rebuilt, contrary to what's in https://webkit-queues.appspot.com/results/1027229
Raphael Kubo da Costa (:rakuco)
Additionally, if it works locally, can you try building with webkit-patch build --no-clean --no-update --port=efl (or efl-wk2) like EWS does?
Michael Catanzaro
Closing this bug because the EFL port has been removed from trunk.
If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.