Bug 118373

Summary: [Windows] Revise handling of CoreGraphics Include Files
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch andersca: review+

Brent Fulgham
Reported 2013-07-03 16:44:50 PDT
Different version of the CoreGraphics library require different compiler features. The VS2010 build does not provide some definitions needed by newer versions of CoreGraphics. This patch allows VS2010 to build these newer sources.
Attachments
Patch (96.66 KB, patch)
2013-07-03 16:49 PDT, Brent Fulgham 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-07-03 16:49:26 PDT
Created attachment 206035 [details] Patch
Radar WebKit Bug Importer
Comment 2 2013-07-03 16:50:15 PDT
<rdar://problem/14351106>
WebKit Commit Bot
Comment 3 2013-07-03 16:51:02 PDT
Attachment 206035 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCorePrefix.h']" exit_code: 1 Source/WebCore/WebCorePrefix.h:146: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/WebCorePrefix.h:147: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 4 2013-07-03 16:53:01 PDT
Comment on attachment 206035 [details] Patch Looks good, but I don’t think you meant to include the whitespace changes in the Change Log.
Brent Fulgham
Comment 5 2013-07-03 17:02:42 PDT
Committed r152383: <http://trac.webkit.org/changeset/152383>
Note You need to log in before you can comment on or make changes to this bug.