Bug 118356 – [Curl] Download does not replace existing file.

• Component: WebCore Misc.
• Status: RESOLVED FIXED

If the download target file already exists, it is not replaced after the download has finished.
At this point, the user would have already approved to replace the file, so it should be replaced.

Created attachment 205997 [details]
Patch

[Peter Gal]

Well I'm not a reviewer but this looks good to me. 

I've just got one (two) question(s) if the MoveFileEx fails then the old file will be still there? and if so won't that cause problems?

(In reply to comment #2)
> Well I'm not a reviewer but this looks good to me. 
> 
> I've just got one (two) question(s) if the MoveFileEx fails then the old file will be still there? and if so won't that cause problems?

Thanks for commenting :)

I think this scenario should be ok, as the old file is a temporary file in a Windows temp folder. The next download will generate a new, unique, temporary file name, to download to, and not have any references to the previous temporary file.

[Brent Fulgham]

Comment on attachment 205997 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 205997 [details]
Patch

Clearing flags on attachment: 205997

Committed r152649: <http://trac.webkit.org/changeset/152649>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

(In reply to comment #4)
> (From update of attachment 205997 [details])
> r=me

Thanks for reviewing!