Bug 118347 – Update blocked/missing plug-in UI

• Component: Plug-ins
• Status: RESOLVED FIXED

[Antoine Quint]

We should display a more specific message when a plug-in is missing or blocked such that it's more obvious to the user what this message means and what the user can do to fix the situation.

[Antoine Quint]

<rdar://problem/14209318>

[Antoine Quint]

First step is https://bugs.webkit.org/show_bug.cgi?id=118348.

[Antoine Quint]

Created attachment 206091 [details]
Patch

[Antoine Quint]

Created attachment 206093 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 206093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206093&action=review

> Source/WebCore/css/unavailablePlugIns.css:28
> + * Such elements, when the plug-in is blocked or issing, will contain a

Typo: "issing" => "missing"

[Antoine Quint]

(In reply to comment #5)
> (From update of attachment 206093 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206093&action=review
> 
> > Source/WebCore/css/unavailablePlugIns.css:28
> > + * Such elements, when the plug-in is blocked or issing, will contain a
> 
> Typo: "issing" => "missing"

Good catch! It looks like my tree is too stale for EWS bots to apply the patch too, so I'll try to send an updated patch soon.

[Antoine Quint]

Created attachment 206114 [details]
Patch

[Early Warning System Bot]

Comment on attachment 206114 [details]
Patch

Attachment 206114 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/997722

[EFL EWS Bot]

Comment on attachment 206114 [details]
Patch

Attachment 206114 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/942832

[EFL EWS Bot]

Comment on attachment 206114 [details]
Patch

Attachment 206114 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/880972

[Build Bot]

Comment on attachment 206114 [details]
Patch

Attachment 206114 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1030120

[Build Bot]

Comment on attachment 206114 [details]
Patch

Attachment 206114 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/992221

[kov's GTK+ EWS bot]

Comment on attachment 206114 [details]
Patch

Attachment 206114 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1036090

[Tim Horton]

Created attachment 206587 [details]
patch

[WebKit Commit Bot]

Attachment 206587 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/css/CSSDefaultStyleSheets.cpp', u'Source/WebCore/css/unavailablePlugIns.css', u'Source/WebCore/dom/EventListener.h', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.h', u'Source/WebCore/page/ChromeClient.h', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.h', u'Source/WebCore/rendering/RenderWidget.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebChromeClient.h', u'Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/HandleMessage.h', u'Source/WebKit2/UIProcess/API/C/WKPage.h', u'Source/WebKit2/UIProcess/WebLoaderClient.cpp', u'Source/WebKit2/UIProcess/WebLoaderClient.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.messages.in', u'Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1
Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp:130:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/rendering/RenderEmbeddedObject.h:75:  The parameter name "description" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 206587 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206587&action=review

> Source/WebCore/css/unavailablePlugIns.css:65
> +    cursor: hand;

These don't take effect (or even show up in the inspector) for some reason.

[Build Bot]

Comment on attachment 206587 [details]
patch

Attachment 206587 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1062465

New failing tests:
css2.1/20110323/replaced-intrinsic-004.htm
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
http/tests/misc/acid2-pixel.html
http/tests/misc/acid2.html
css2.1/20110323/replaced-intrinsic-002.htm
fast/css/counters/counter-traverse-table-cell.html
http/tests/security/contentSecurityPolicy/object-src-url-blocked.html
http/tests/inspector/inspect-element.html
accessibility/plugin.html
css2.1/20110323/replaced-intrinsic-005.htm
http/tests/security/xss-DENIED-object-element.html
http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm
css2.1/20110323/replaced-intrinsic-ratio-001.htm
plugins/embed-inside-object.html
editing/pasteboard/copy-image-with-alt-text.html
fast/css/acid2.html
fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml
editing/pasteboard/paste-noplugin.html
fullscreen/anonymous-block-merge-crash.html
fast/overflow/overflow-height-float-not-removed-crash3.html
css2.1/20110323/replaced-intrinsic-001.htm
http/tests/misc/acid3.html
fast/forms/input-field-text-truncated.html
css2.1/20110323/replaced-intrinsic-003.htm

[Build Bot]

Created attachment 206608 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Build Bot]

Comment on attachment 206587 [details]
patch

Attachment 206587 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1066542

New failing tests:
http/tests/security/contentSecurityPolicy/object-src-url-allowed.html
css2.1/20110323/replaced-intrinsic-004.htm
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
http/tests/misc/acid2-pixel.html
http/tests/misc/acid2.html
css2.1/20110323/replaced-intrinsic-002.htm
fast/css/counters/counter-traverse-table-cell.html
http/tests/security/contentSecurityPolicy/object-src-url-blocked.html
http/tests/inspector/inspect-element.html
accessibility/plugin.html
css2.1/20110323/replaced-intrinsic-005.htm
http/tests/security/xss-DENIED-object-element.html
http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm
css2.1/20110323/replaced-intrinsic-ratio-001.htm
fast/css/acid2-pixel.html
plugins/embed-inside-object.html
fast/css/acid2.html
http/tests/security/contentSecurityPolicy/object-src-none-allowed.html
fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml
editing/pasteboard/paste-noplugin.html
css2.1/20110323/replaced-intrinsic-003.htm
fast/overflow/overflow-height-float-not-removed-crash3.html
css2.1/20110323/replaced-intrinsic-001.htm
platform/mac/editing/deleting/deletionUI-single-instance.html
http/tests/misc/acid3.html
fullscreen/full-screen-iframe-with-max-width-height.html
fast/loader/javascript-url-in-object.html
fast/forms/input-field-text-truncated.html

[Build Bot]

Created attachment 206633 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Tim Horton]

OK, the failing layout tests have structures like this (this one from css2.1/20110323/replaced-intrinsic-003.htm):

RenderView 0x7fd6a0d36778              	#document	0x7fd6a4803a00
  RenderBlock 0x7fd6a0c39e18           	HTML	0x7fd6a0c05fe0
    RenderBody 0x7fd6a0c44818          	BODY	0x7fd6a0c3faa0
      RenderBlock 0x7fd6a0c47828       	DIV	0x7fd6a0c44da0
        RenderBlock 0x7fd6a0c4a808     	P	0x7fd6a0c47410
          RenderEmbeddedObject 0x7fd6a0c4f378	OBJECT	0x7fd6a0c4a8f0
*           RenderText 0x7fd6a0c4ae28  	#text	0x7fd6a0e47980 " FAIL (SVG not supported) "

The layout and paint stuff the patch adds to REO assumes the child is a RenderBox, which is silly.

[Tim Horton]

Created attachment 206702 [details]
patch

[Tim Horton]

Created attachment 206703 [details]
patch

[WebKit Commit Bot]

Attachment 206703 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/css/CSSDefaultStyleSheets.cpp', u'Source/WebCore/css/unavailablePlugIns.css', u'Source/WebCore/dom/EventListener.h', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/page/ChromeClient.h', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.h', u'Source/WebCore/rendering/RenderWidget.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebChromeClient.h', u'Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/HandleMessage.h', u'Source/WebKit2/UIProcess/API/C/WKPage.h', u'Source/WebKit2/UIProcess/WebLoaderClient.cpp', u'Source/WebKit2/UIProcess/WebLoaderClient.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.messages.in', u'Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1
Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp:130:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/rendering/RenderEmbeddedObject.h:75:  The parameter name "description" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Created attachment 206704 [details]
patch

[Sam Weinig]

Comment on attachment 206704 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206704&action=review

> Source/WebCore/ChangeLog:8
> +        Patch by Anders Carlsson, Antoine Quint, Sam Weinig, and myself.

Did I contribute to this? I remember this not.

> Source/WebCore/rendering/RenderEmbeddedObject.cpp:299
> +    LayoutRect rect;
> +    if (m_indicator && m_indicator->renderer())
> +        rect = m_indicator->renderer()->absoluteBoundingBoxRect();
> +    else
> +        rect = LayoutRect();
> +

Is the else statement necessary?

[Tim Horton]

(In reply to comment #26)
> (From update of attachment 206704 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206704&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Patch by Anders Carlsson, Antoine Quint, Sam Weinig, and myself.
> 
> Did I contribute to this? I remember this not.

Some! The out-args WK2 stuff :)

> > Source/WebCore/rendering/RenderEmbeddedObject.cpp:299
> > +    LayoutRect rect;
> > +    if (m_indicator && m_indicator->renderer())
> > +        rect = m_indicator->renderer()->absoluteBoundingBoxRect();
> > +    else
> > +        rect = LayoutRect();
> > +
> 
> Is the else statement necessary?

Ha. No. Thanks, Sam!

[Tim Horton]

Created attachment 206716 [details]
patch

Sam reminded me that we need to not change the signature of pluginLoadPolicy, so deprecate it and add a new one.

[Tim Horton]

Comment on attachment 206716 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206716&action=review

> Tools/WebKitTestRunner/TestController.cpp:488
> +        0, // pluginLoadPolicy_deprecatedForUseWithV1

Typo, should say v2.

[Tim Horton]

Comment on attachment 206716 [details]
patch

Landed with Sam's prior review (hopefully that's OK). http://trac.webkit.org/changeset/152701

[WebKit Commit Bot]

Re-opened since this is blocked by bug 118821

[Tim Horton]

Created attachment 206933 [details]
new patch with no shadow dom

[Tim Horton]

http://trac.webkit.org/changeset/152824