Bug 118303

Summary: [Curl] Crash after download.
Product: WebKit Reporter: peavo
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, galpeter
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description peavo 2013-07-02 06:58:59 PDT 
I sometimes get a crash in Curl after a download has finished.
The reason is that the Curl easy handle for the download has been deleted before it has been removed from the Curl multi handle.
We need to make sure that the easy handle is removed from the Curl multi handle before it's freed.
Comment 1 peavo 2013-07-02 07:08:19 PDT 
Created attachment 205909 [details]
Patch
Comment 2 Brent Fulgham 2013-07-02 09:22:47 PDT 
Comment on attachment 205909 [details]
Patch

r=me.  A nice solution to this problem!
Comment 3 WebKit Commit Bot 2013-07-02 09:26:45 PDT 
Comment on attachment 205909 [details]
Patch

Clearing flags on attachment: 205909

Committed r152297: <http://trac.webkit.org/changeset/152297>
Comment 4 WebKit Commit Bot 2013-07-02 09:26:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 peavo 2013-07-02 11:20:17 PDT 
(In reply to comment #2)
> (From update of attachment 205909 [details])
> r=me.  A nice solution to this problem!

Thanks for the review ;)