Summary: | JS SVG POD types do not work properly when being assigned | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||
Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Critical | ||||||
Priority: | P2 | ||||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
Nikolas Zimmermann
2006-12-14 12:04:42 PST
Created attachment 11841 [details]
Initial patch
No new regressions, none fixed. Can't create a LayoutTest for this, as things only break, if you apply my SVGLength* -> SVGLength patch and do NOT have this patch yet.
Comment on attachment 11841 [details]
Initial patch
I think there's some const missing here. Since SVGMatrix is immutable, I think the AffineTransform inside an SVGMatrix should be const.
Regardless, r=me
(In reply to comment #2) > (From update of attachment 11841 [details] [edit]) > I think there's some const missing here. Since SVGMatrix is immutable, I think > the AffineTransform inside an SVGMatrix should be const. > > Regardless, r=me Thanks a lot for the quick review! You mean in JSSVGMatrixCustom.cpp, regarding the const? Niko |