Bug 118283

Summary: Remove SVGStyledLocatableElement class
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: SVGAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, d-r, fmalita, gyuyoung.kim, krit, pdr, rakuco, rwlbuis, schenney, thorton, zimmermann
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
krit: review+
Patch for landing none

Chris Dumez
Reported 2013-07-01 23:16:10 PDT
Remove SVGStyledLocatableElement class and have SVGGraphicsElement inherit SVGStyledElement directly instead. SVGStyledLocatableElement is no longer needed and according to the specification, SVGGraphicsElement should inherit SVGStyledElement (actually SVGElement once we merge SVGStyledElement into SVGElement). Corresponding Blink revision: https://src.chromium.org/viewvc/blink?revision=153347&view=revision
Attachments
Patch (33.18 KB, patch)
2013-07-01 23:53 PDT, Chris Dumez 		krit: review+
DetailsFormatted DiffDiff
Patch for landing (32.01 KB, patch)
2013-07-02 09:06 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-07-01 23:53:23 PDT
Created attachment 205872 [details] Patch
Dirk Schulze
Comment 2 2013-07-02 08:37:14 PDT
Comment on attachment 205872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205872&action=review r=me but please fix the indentation problem on the Xcode file. > Source/WebCore/WebCore.xcodeproj/project.pbxproj:26708 > - B2227AB30D00BF220071B782 /* SVGStyledLocatableElement.cpp in Sources */, > + B2227AB70D00BF220071B783 /* SVGStyledElement.cpp in Sources */, Indentation is wrong. Same for the other lines.
Chris Dumez
Comment 3 2013-07-02 08:44:16 PDT
Comment on attachment 205872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205872&action=review >> Source/WebCore/WebCore.xcodeproj/project.pbxproj:26708 >> + B2227AB70D00BF220071B783 /* SVGStyledElement.cpp in Sources */, > > Indentation is wrong. Same for the other lines. Oops. looks like my editor replaced the tabs with spaces :( Thanks for catching it.
Chris Dumez
Comment 4 2013-07-02 09:06:52 PDT
Created attachment 205920 [details] Patch for landing
WebKit Commit Bot
Comment 5 2013-07-02 10:38:15 PDT
Comment on attachment 205920 [details] Patch for landing Clearing flags on attachment: 205920 Committed r152299: <http://trac.webkit.org/changeset/152299>
WebKit Commit Bot
Comment 6 2013-07-02 10:38:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.