Bug 11827
| Summary: | REGRESSION(r18203): Drag-n-drop layout test failures | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Major | CC: | andersca, beidson, hyatt, mitz, mjs |
| Priority: | P1 | Keywords: | LayoutTestFailure, Regression |
| Version: | 420+ | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
David Kilzer (:ddkilzer)
The following drag-n-drop layout tests regressed between r18203 and r18205:
editing/pasteboard/drag-drop-modifies-page
editing/pasteboard/subframe-dragndrop-1
fast/events/ondragenter
fast/forms/drag-into-textarea
fast/lists/drag-into-marker
Unfortunately the BuildBot didn't provide individual builds for these revisions.
Note that this is NOT related to Bug 11825 which Hyatt fixed later.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
mitz
According to Anders on IRC, the bug originated from this change in r18203:
NSURL *KURL::getNSURL() const
{
+ // FIXME: CFURL can't hold an empty URL, unlike NSURL
+ if (isEmpty())
+ return [NSURL URLWithString:@""];
+
In addition to the test failures, you can easily see the bug by dragging any selected text, which results in an empty URL being dragged. Another effect is that the Safari status bar reads "Open "" in a new window" whenever the mouse pointer is over something that is not a link.
David Kilzer (:ddkilzer)
Fixed by mjs in r18227.