Summary: | DrawingBuffer has unused functions | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
Component: | WebGL | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Minor | CC: | buildbot, commit-queue, eflews.bot, gyuyoung.kim, rniwa, sam, webkit-ews | ||||||||
Priority: | P3 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Alex Christensen
2013-07-01 11:11:13 PDT
Created attachment 205824 [details]
Patch
Comment on attachment 205824 [details] Patch Attachment 205824 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/877871 Comment on attachment 205824 [details] Patch Attachment 205824 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1014268 Comment on attachment 205824 [details] Patch Attachment 205824 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1013277 Comment on attachment 205824 [details] Patch Attachment 205824 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1014269 OK. I was a bit too aggressive. paintCompositedResultsToCanvas is still used, but I don't think the others are Created attachment 205825 [details]
Patch
Comment on attachment 205825 [details] Patch Rejecting attachment 205825 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 205825, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/877876 Created attachment 205826 [details]
Patch
Comment on attachment 205826 [details] Patch Clearing flags on attachment: 205826 Committed r152240: <http://trac.webkit.org/changeset/152240> All reviewed patches have been landed. Closing bug. |