Bug 118257

Summary: DrawingBuffer has unused functions
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: buildbot, commit-queue, eflews.bot, gyuyoung.kim, rniwa, sam, webkit-ews
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2013-07-01 11:11:13 PDT
Since the removal of Chromium code in r147775, these functions have not been used in any platform. They don't do anything, or they just return false and are never called, so I suggest they be removed. DrawingBuffer::prepareBackBuffer, DrawingBuffer::requiresCopyFromBackToFrontBuffer, DrawingBuffer::paintCompositedResultsToCanvas, and DrawingBuffer::clearPlatformLayer
Attachments
Patch (7.54 KB, patch)
2013-07-01 11:13 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (6.24 KB, patch)
2013-07-01 11:27 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (6.20 KB, patch)
2013-07-01 11:39 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-07-01 11:13:41 PDT
Created attachment 205824 [details] Patch
EFL EWS Bot
Comment 2 2013-07-01 11:17:12 PDT
Comment on attachment 205824 [details] Patch Attachment 205824 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/877871
Build Bot
Comment 3 2013-07-01 11:18:18 PDT
Comment on attachment 205824 [details] Patch Attachment 205824 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1014268
Early Warning System Bot
Comment 4 2013-07-01 11:18:39 PDT
Comment on attachment 205824 [details] Patch Attachment 205824 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1013277
Early Warning System Bot
Comment 5 2013-07-01 11:20:03 PDT
Comment on attachment 205824 [details] Patch Attachment 205824 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1014269
Alex Christensen
Comment 6 2013-07-01 11:22:05 PDT
OK. I was a bit too aggressive. paintCompositedResultsToCanvas is still used, but I don't think the others are
Alex Christensen
Comment 7 2013-07-01 11:27:00 PDT
Created attachment 205825 [details] Patch
WebKit Commit Bot
Comment 8 2013-07-01 11:33:27 PDT
Comment on attachment 205825 [details] Patch Rejecting attachment 205825 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 205825, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/877876
Alex Christensen
Comment 9 2013-07-01 11:39:49 PDT
Created attachment 205826 [details] Patch
WebKit Commit Bot
Comment 10 2013-07-01 12:48:52 PDT
Comment on attachment 205826 [details] Patch Clearing flags on attachment: 205826 Committed r152240: <http://trac.webkit.org/changeset/152240>
WebKit Commit Bot
Comment 11 2013-07-01 12:48:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.