Bug 118229

Summary: [Windows] WebKitSupportLibs version difference makes the install and build unsuccesful
Product: WebKit Reporter: Vivek Galatage <vivekg>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: arpitabahuguna, bfulgham, peavo, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   

Description Vivek Galatage 2013-06-30 23:43:39 PDT
I am trying to setup windows environment for webkit build. 

I downloaded the WebKitSupportLibs.zip from http://developer.apple.com/opensource/internet/webkit_sptlib_agree.html

The WebKitSupportLibraryVersion included in the zip file has the value '5' whereas https://developer.apple.com/opensource/internet/WebKitSupportLibraryVersion return '4' due to which the installation fails:

===============================================================================
WebKitSupportLibrary.zip is out-of-date.
Please download WebKitSupportLibrary.zip from:

    https://developer.apple.com/opensource/internet/webkit_sptlib_agree.html

and place it in:

    /cygdrive/e/webkit

Then run build-webkit again.
===============================================================================

Died at Tools/Scripts/build-webkit line 242.


Also the build gives the following errors:

Cannot open include file: 'Security/Security.h': No such file or directory
Cannot open include file: 'ImageIO/ImageIOBase.h': No such file or directory

But these files are also missing from the above zip file.
Comment 1 Roger Fong 2013-07-01 19:06:48 PDT
(In reply to comment #0)
> I am trying to setup windows environment for webkit build. 
> 
> I downloaded the WebKitSupportLibs.zip from http://developer.apple.com/opensource/internet/webkit_sptlib_agree.html
> 
> The WebKitSupportLibraryVersion included in the zip file has the value '5' whereas https://developer.apple.com/opensource/internet/WebKitSupportLibraryVersion return '4' due to which the installation fails:
> 

I can fix that.
> ===============================================================================
> WebKitSupportLibrary.zip is out-of-date.
> Please download WebKitSupportLibrary.zip from:
> 
>     https://developer.apple.com/opensource/internet/webkit_sptlib_agree.html
> 
> and place it in:
> 
>     /cygdrive/e/webkit
> 
> Then run build-webkit again.
> ===============================================================================
> 
> Died at Tools/Scripts/build-webkit line 242.
> 
> 
> Also the build gives the following errors:
> 
> Cannot open include file: 'Security/Security.h': No such file or directory
> Cannot open include file: 'ImageIO/ImageIOBase.h': No such file or directory
> 
> But these files are also missing from the abongeve zip file.

This one is strange. Our open source bots are using the same zips and don't have those headers either but are building fine.

From which file are you getting those missing include file errors?
Comment 2 Vivek Galatage 2013-07-01 19:50:23 PDT
(In reply to comment #1)
> I can fix that.

That would be great. Thank you!

> > Also the build gives the following errors:
> > 
> > Cannot open include file: 'Security/Security.h': No such file or directory
> > Cannot open include file: 'ImageIO/ImageIOBase.h': No such file or directory
> > 
> > But these files are also missing from the abongeve zip file.
> 
> This one is strange. Our open source bots are using the same zips and don't have those headers either but are building fine.
> 
> From which file are you getting those missing include file errors?

These are the errors. http://pastebin.com/raw.php?i=jqch255M
Comment 3 peavo 2013-07-03 02:20:50 PDT
(In reply to comment #2)

> > > Cannot open include file: 'Security/Security.h': No such file or directory
> > > Cannot open include file: 'ImageIO/ImageIOBase.h': No such file or directory

I'm also getting the compile errors.
Comment 4 Roger Fong 2013-07-03 09:27:27 PDT
There's more than just those I believe.
Are bots were apparently using the wrong zip file which is why they weren't breaking but I'm seeing the errors now that I've switched to the right one.
I'll try to get the Opensource builds up and running again sometime today.
Comment 5 Vivek Galatage 2013-07-03 10:15:57 PDT
(In reply to comment #4)
> There's more than just those I believe.
> Are bots were apparently using the wrong zip file which is why they weren't breaking but I'm seeing the errors now that I've switched to the right one.
> I'll try to get the Opensource builds up and running again sometime today.

Sounds great. Will you be also uploading the same zip file at the URL (http://developer.apple.com/opensource/internet/webkit_sptlib_agree.html) so that we can also update the local zip file accordingly? Thank you!
Comment 6 Roger Fong 2013-07-03 17:37:52 PDT
How urgent is this for you guys? Do you still have your old support lib zips and can you workaround things to get a successful build?

I haven't had a chance to work on this today and am leaving for vacation until monday starting tomorrow.
It's unfortunately a bit more than just sticking some more headers in the zip files because I need to get approval to release certain headers ... ick.

If you still have the old support libraries lying around somewhere I'd suggest you use those, or try to comment out the includes that are failing and see if that fixes things...
Comment 7 Vivek Galatage 2013-07-03 17:41:39 PDT
(In reply to comment #6)
> How urgent is this for you guys? Do you still have your old support lib zips and can you workaround things to get a successful build?
> 
> I haven't had a chance to work on this today and am leaving for vacation until monday starting tomorrow.
> It's unfortunately a bit more than just sticking some more headers in the zip files because I need to get approval to release certain headers ... ick.
> 
> If you still have the old support libraries lying around somewhere I'd suggest you use those, or try to comment out the includes that are failing and see if that fixes things...

Sure, it can wait. In the meanwhile I can try commenting out the missing headers. Thanks and have a nice vacation. :-)
Comment 8 Vivek Galatage 2013-07-15 01:33:03 PDT
(In reply to comment #7)
> Sure, it can wait. In the meanwhile I can try commenting out the missing headers. Thanks and have a nice vacation. :-)

Do you have any updates regarding the library headers? As we are still facing the same issue. Thanks!
Comment 9 Roger Fong 2013-07-15 09:58:52 PDT
I'm one header fix away! Will be done today.
Comment 10 Roger Fong 2013-07-15 13:55:32 PDT
Ok we should be good to go now.
Make sure you have the DirectXSDK installed (the latest June2010 one will work).
Comment 11 Vivek Galatage 2013-07-15 20:54:04 PDT
(In reply to comment #10)
> Ok we should be good to go now.
> Make sure you have the DirectXSDK installed (the latest June2010 one will work).

Working perfectly. Thank you for the resolution.