Summary: | DeprecatedStringData allocation size is 52 bytes due to struct packing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Fisher (:fishd, Google) <fishd> | ||||
Component: | Platform | Assignee: | Darin Fisher (:fishd, Google) <fishd> | ||||
Status: | RESOLVED WONTFIX | ||||||
Severity: | Minor | ||||||
Priority: | P3 | ||||||
Version: | 420+ | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Attachments: |
|
Description
Darin Fisher (:fishd, Google)
2006-12-13 15:38:27 PST
Created attachment 11874 [details]
patch
I haven't determined if this actually is necessary, but here's a patch.
Comment on attachment 11874 [details]
patch
I don't think we want to make this change without knowing what it accomplishes or being able to test it.
Building mysterious code on top of mysterious comments seems like a recipe for either (a) disaster or (b) a sequel to the Da Vinci Code.
I think this comment was specific to the size classes of the Mac OS X system malloc. But WebKit will no longer use that, even on Mac OS X, so I think the best thing would be to remove the comment. My hope was that one of you guys would know what this comment was all about and be able to decide whether you want the same for windows or if the comment is just bogus. Sounds like the latter, so I'll rev the patch accordingly. |