Avoid calling RenderLayerBacking::resetContentsRect() if possible

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Calling RenderLayerBacking::resetContentsRect() every time from updateGraphicsLayerGeometry() shows up on profiles, because calling enderer())->contentBoxRect() involves a bunch of virtual function calls. And we only need to call resetContentsRect() when the image tiling stuff has changed it, so calling this every time is overkill.

[Noam Rosenthal]

(In reply to comment #0)
> Calling RenderLayerBacking::resetContentsRect() every time from updateGraphicsLayerGeometry() shows up on profiles, because calling enderer())->contentBoxRect() involves a bunch of virtual function calls. And we only need to call resetContentsRect() when the image tiling stuff has changed it, so calling this every time is overkill.

We also need to call resetContentsRect when the contentsRect of the RenderObject has changed; Previously we were calling setContentsRect(renderer()->contentsBox()) in updateGraphicsLayerGeometry() so this behavior has not changed (though now it appears in profile since it's in its own function...).

[Noam Rosenthal]

Created attachment 205804 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 205804 [details]
Patch

Clearing flags on attachment: 205804

Committed r152227: <http://trac.webkit.org/changeset/152227>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

This caused bug 118951.