Bug 118217

Summary: Avoid calling RenderLayerBacking::resetContentsRect() if possible
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, esprehn+autocc, glenn, luiz, noam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2013-06-29 12:35:49 PDT
Calling RenderLayerBacking::resetContentsRect() every time from updateGraphicsLayerGeometry() shows up on profiles, because calling enderer())->contentBoxRect() involves a bunch of virtual function calls. And we only need to call resetContentsRect() when the image tiling stuff has changed it, so calling this every time is overkill.
Attachments
Patch (3.53 KB, patch)
2013-07-01 06:13 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2013-06-29 14:19:23 PDT
(In reply to comment #0) > Calling RenderLayerBacking::resetContentsRect() every time from updateGraphicsLayerGeometry() shows up on profiles, because calling enderer())->contentBoxRect() involves a bunch of virtual function calls. And we only need to call resetContentsRect() when the image tiling stuff has changed it, so calling this every time is overkill. We also need to call resetContentsRect when the contentsRect of the RenderObject has changed; Previously we were calling setContentsRect(renderer()->contentsBox()) in updateGraphicsLayerGeometry() so this behavior has not changed (though now it appears in profile since it's in its own function...).
Noam Rosenthal
Comment 2 2013-07-01 06:13:29 PDT
Created attachment 205804 [details] Patch
WebKit Commit Bot
Comment 3 2013-07-01 09:32:48 PDT
Comment on attachment 205804 [details] Patch Clearing flags on attachment: 205804 Committed r152227: <http://trac.webkit.org/changeset/152227>
WebKit Commit Bot
Comment 4 2013-07-01 09:32:50 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5 2013-07-22 12:33:55 PDT
This caused bug 118951.
Note You need to log in before you can comment on or make changes to this bug.