Bug 118136

Summary: [BlackBerry] We should clear all markers when input changes a word
Product: WebKit Reporter: Nima Ghanavatian <nghanavatian>
Component: WebKit BlackBerryAssignee: Nima Ghanavatian <nghanavatian>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Nima Ghanavatian
Reported 2013-06-27 07:57:40 PDT
For the case where a letter is added to the middle of a misspelled word, we were sending incorrect offsets to clear spelling markers. However, since this expanded the current word, it overlaps entirely the previous spelling marker so no issue is found. However, if the keypress is backspace, the incorrect range is smaller, causing an overlap which recreates the marker over the last character. Setting shouldEraseMarkersAfterChangeSelection to follow continuous spell checking, which will clear all markers regardless of overlap. This patch also sustains spelling markers after the user taps to move the caret onto the word, which is a nice gain as it was asked for previously.
Attachments
Patch (2.48 KB, patch)
2013-06-27 08:02 PDT, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nima Ghanavatian
Comment 1 2013-06-27 08:02:00 PDT
Created attachment 205609 [details] Patch
Rob Buis
Comment 2 2013-06-27 08:20:12 PDT
Comment on attachment 205609 [details] Patch Looks good.
WebKit Commit Bot
Comment 3 2013-06-27 09:33:24 PDT
Comment on attachment 205609 [details] Patch Clearing flags on attachment: 205609 Committed r152102: <http://trac.webkit.org/changeset/152102>
WebKit Commit Bot
Comment 4 2013-06-27 09:33:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.