Summary: | SVGLength needs a rewrite | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||||||||||||
Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | ||||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 420+ | ||||||||||||||||
Hardware: | Mac | ||||||||||||||||
OS: | OS X 10.4 | ||||||||||||||||
Attachments: |
|
Description
Nikolas Zimmermann
2006-12-12 10:16:00 PST
Created attachment 11824 [details]
First patch, not ready for review yet
This patch compiles & links, but it still has some subtle bugs related to coordinate handling & fractions, and the new JS put() logic doesn't seem to work reliable yet. It doesn't crash but clearle shows memory corruption (ie. createSVGNumber() returns some weird 9.38E30 values....)
I just want to keep the patch here so Rob & others can have a look at it, too.
Created attachment 11846 [details]
Second patch, not ready for review yet
Now that JS SVG POD types are fixed, SVGLength can be converted, finally.
This patch is complete, compiles & links, but still has some issues with
two tests (svg length fraction handling). This is likely, as SVGLength
has been completely rewritten :-)
I'll try to fix them tomorrow...
Attaching patch for early birds..
Created attachment 11880 [details]
No regressions
These changes to Niko's patch should fix the regressions.
Cheers,
Rob.
Created attachment 11885 [details]
Updated patch
Finally a complete patch, with no regressions! :-)
Credits go to Rob for fixing the last (very important!) regression,
which I was unable to find for quite some days...
Created attachment 11889 [details]
Updated patch II
We still found a problem when manually testing, uploading latest patch for Rob & Oliver.
Created attachment 11893 [details]
Final patch
All regressions fixed now! :-)
|