Bug 118125

Summary:

Move WindowsExtras.h from WebCore to WTF

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

Platform

Assignee:

Patrick R. Gansterer <paroga>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, bfulgham, cmarcelo, commit-queue, eric.carlson, glenn, jer.noble, roger_fong

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

Windows 7

Bug Depends on:

Bug Blocks:

116606

Attachments:

Description	Flags
Patch	none
Patch	none

Description Patrick R. Gansterer 2013-06-27 04:48:34 PDT

Move WindowsExtras.h from WebCore to WTF

Comment 1 Patrick R. Gansterer 2013-06-27 04:53:10 PDT

Created attachment 205589 [details]
Patch

Comment 2 WebKit Commit Bot 2013-06-27 04:55:59 PDT

Attachment 205589 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/WindowsExtras.h', u'Source/WTF/wtf/win/MainThreadWin.cpp', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/PlatformKeyboardEvent.h', u'Source/WebCore/platform/PlatformMouseEvent.h', u'Source/WebCore/platform/PlatformWheelEvent.h', u'Source/WebCore/platform/win/PasteboardWin.cpp', u'Source/WebCore/platform/win/PopupMenuWin.cpp', u'Source/WebCore/platform/win/RunLoopWin.cpp', u'Source/WebCore/platform/win/SharedTimerWin.cpp', u'Source/WebCore/platform/win/WindowMessageListener.h', u'Source/WebCore/platform/win/WindowsExtras.h']" exit_code: 1
Source/WTF/wtf/WindowsExtras.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WTF/wtf/WindowsExtras.h:35:  HWND_MESSAGE is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Build Bot 2013-06-27 09:02:41 PDT

Comment on attachment 205589 [details]
Patch

Attachment 205589 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/866377

Comment 4 Patrick R. Gansterer 2013-07-04 02:30:43 PDT

Created attachment 206068 [details]
Patch

Comment 5 WebKit Commit Bot 2013-07-04 02:33:40 PDT

Attachment 206068 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/WindowsExtras.h', u'Source/WTF/wtf/win/MainThreadWin.cpp', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/PlatformKeyboardEvent.h', u'Source/WebCore/platform/PlatformMouseEvent.h', u'Source/WebCore/platform/PlatformWheelEvent.h', u'Source/WebCore/platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h', u'Source/WebCore/platform/win/MIMETypeRegistryWin.cpp', u'Source/WebCore/platform/win/PasteboardWin.cpp', u'Source/WebCore/platform/win/PopupMenuWin.cpp', u'Source/WebCore/platform/win/RunLoopWin.cpp', u'Source/WebCore/platform/win/SharedTimerWin.cpp', u'Source/WebCore/platform/win/WindowMessageListener.h', u'Source/WebCore/platform/win/WindowsExtras.h', u'Source/WebCore/plugins/win/PluginDatabaseWin.cpp']" exit_code: 1
Source/WTF/wtf/WindowsExtras.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WTF/wtf/WindowsExtras.h:35:  HWND_MESSAGE is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 6 WebKit Commit Bot 2013-07-30 11:53:07 PDT

Comment on attachment 206068 [details]
Patch

Clearing flags on attachment: 206068

Committed r153483: <http://trac.webkit.org/changeset/153483>

Comment 7 WebKit Commit Bot 2013-07-30 11:53:09 PDT

All reviewed patches have been landed.  Closing bug.