Bug 118125

Summary: Move WindowsExtras.h from WebCore to WTF
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cmarcelo, commit-queue, eric.carlson, glenn, jer.noble, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Windows 7   
Bug Depends on:    
Bug Blocks: 116606    
Attachments:
Description Flags
Patch
none
Patch none

Patrick R. Gansterer
Reported 2013-06-27 04:48:34 PDT
Move WindowsExtras.h from WebCore to WTF
Attachments
Patch (12.10 KB, patch)
2013-06-27 04:53 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (14.95 KB, patch)
2013-07-04 02:30 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2013-06-27 04:53:10 PDT
Created attachment 205589 [details] Patch
WebKit Commit Bot
Comment 2 2013-06-27 04:55:59 PDT
Attachment 205589 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/WindowsExtras.h', u'Source/WTF/wtf/win/MainThreadWin.cpp', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/PlatformKeyboardEvent.h', u'Source/WebCore/platform/PlatformMouseEvent.h', u'Source/WebCore/platform/PlatformWheelEvent.h', u'Source/WebCore/platform/win/PasteboardWin.cpp', u'Source/WebCore/platform/win/PopupMenuWin.cpp', u'Source/WebCore/platform/win/RunLoopWin.cpp', u'Source/WebCore/platform/win/SharedTimerWin.cpp', u'Source/WebCore/platform/win/WindowMessageListener.h', u'Source/WebCore/platform/win/WindowsExtras.h']" exit_code: 1 Source/WTF/wtf/WindowsExtras.h:30: Alphabetical sorting problem. [build/include_order] [4] Source/WTF/wtf/WindowsExtras.h:35: HWND_MESSAGE is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2013-06-27 09:02:41 PDT
Comment on attachment 205589 [details] Patch Attachment 205589 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/866377
Patrick R. Gansterer
Comment 4 2013-07-04 02:30:43 PDT
Created attachment 206068 [details] Patch
WebKit Commit Bot
Comment 5 2013-07-04 02:33:40 PDT
Attachment 206068 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/WindowsExtras.h', u'Source/WTF/wtf/win/MainThreadWin.cpp', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/PlatformKeyboardEvent.h', u'Source/WebCore/platform/PlatformMouseEvent.h', u'Source/WebCore/platform/PlatformWheelEvent.h', u'Source/WebCore/platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h', u'Source/WebCore/platform/win/MIMETypeRegistryWin.cpp', u'Source/WebCore/platform/win/PasteboardWin.cpp', u'Source/WebCore/platform/win/PopupMenuWin.cpp', u'Source/WebCore/platform/win/RunLoopWin.cpp', u'Source/WebCore/platform/win/SharedTimerWin.cpp', u'Source/WebCore/platform/win/WindowMessageListener.h', u'Source/WebCore/platform/win/WindowsExtras.h', u'Source/WebCore/plugins/win/PluginDatabaseWin.cpp']" exit_code: 1 Source/WTF/wtf/WindowsExtras.h:30: Alphabetical sorting problem. [build/include_order] [4] Source/WTF/wtf/WindowsExtras.h:35: HWND_MESSAGE is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 6 2013-07-30 11:53:07 PDT
Comment on attachment 206068 [details] Patch Clearing flags on attachment: 206068 Committed r153483: <http://trac.webkit.org/changeset/153483>
WebKit Commit Bot
Comment 7 2013-07-30 11:53:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.