Bug 118069

Summary:

Prepare CaptionUserPreferencesMac for use on Windows port

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Media

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, glenn, jer.noble, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Update to correct some style warnings.	eric.carlson: review+

Brent Fulgham

Reported 2013-06-26 10:24:00 PDT

Prepare the CaptionUserPreferencesMac class to be usable on the Apple Windows port by: 1. Renaming it to CaptionUserPreferencesMediaAF.cpp 2. Making minor changes to compile with C++. This change should create no changes in behavior, and will be followed by a Windows-specific patch to turn on various features.

Attachments
Patch (110.00 KB, patch) 2013-06-26 11:21 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Update to correct some style warnings. (114.19 KB, patch) 2013-06-26 11:26 PDT, Brent Fulgham	eric.carlson: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2013-06-26 11:21:51 PDT

Created attachment 205510 [details] Patch

WebKit Commit Bot

Comment 2 2013-06-26 11:22:42 PDT

Attachment 205510 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/page/CaptionUserPreferencesMac.h', u'Source/WebCore/page/CaptionUserPreferencesMac.mm', u'Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp', u'Source/WebCore/page/CaptionUserPreferencesMediaAF.h', u'Source/WebCore/page/PageGroup.cpp']" exit_code: 1 Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:149: Missing space before { [whitespace/braces] [5] Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:168: Use 0 instead of NULL. [readability/null] [5] Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:207: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:254: Use 0 instead of NULL. [readability/null] [5] Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:415: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:524: One space before end of line comments [whitespace/comments] [5] Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:572: One space before end of line comments [whitespace/comments] [5] Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:839: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 8 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brent Fulgham

Comment 3 2013-06-26 11:26:50 PDT

Created attachment 205511 [details] Update to correct some style warnings.

Brent Fulgham

Comment 4 2013-06-26 11:27:55 PDT

(In reply to comment #2) > Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:149: Missing space before { [whitespace/braces] [5] I don't think we want to modify this Block syntax.

Radar WebKit Bug Importer

Comment 5 2013-06-26 11:28:48 PDT

<rdar://problem/14278574>

WebKit Commit Bot

Comment 6 2013-06-26 11:29:20 PDT

Attachment 205511 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/page/CaptionUserPreferencesMac.h', u'Source/WebCore/page/CaptionUserPreferencesMac.mm', u'Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp', u'Source/WebCore/page/CaptionUserPreferencesMediaAF.h', u'Source/WebCore/page/PageGroup.cpp']" exit_code: 1 Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:149: Missing space before { [whitespace/braces] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brent Fulgham

Comment 7 2013-06-26 11:40:27 PDT

(In reply to comment #6) > Attachment 205511 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/page/CaptionUserPreferencesMac.h', u'Source/WebCore/page/CaptionUserPreferencesMac.mm', u'Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp', u'Source/WebCore/page/CaptionUserPreferencesMediaAF.h', u'Source/WebCore/page/PageGroup.cpp']" exit_code: 1 > Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:149: Missing space before { [whitespace/braces] [5] > Total errors found: 1 in 7 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. Bug 118072 was filed to encourage check-webkit-style to recognize Block syntax.

Brent Fulgham

Comment 8 2013-06-26 11:49:31 PDT

Committed r152004: <http://trac.webkit.org/changeset/152004>

Note You need to log in before you can comment on or make changes to this bug.