Bug 118063

Summary: Functions created from source are not reported to the debugger
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: JavaScriptCoreAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, fpizlo, ggaren, graouts, joepeck, oliver, rniwa, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ggaren: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 none

Description Timothy Hatcher 2013-06-26 08:26:41 PDT
Given the following script:

var f = new Function("a", "b", "return a + b");
f(2, 3);

The source code for the function will not be reported to the Debugger::sourceParsed callback and will not be visible to the Web Inspector. This also happens does not happen for functions created by WebCore::JSLazyEventListener.

<rdar://problem/12679475>
Comment 1 Timothy Hatcher 2013-06-26 08:30:00 PDT
Created attachment 205497 [details]
Patch
Comment 2 Geoffrey Garen 2013-06-26 08:40:02 PDT
Comment on attachment 205497 [details]
Patch

Can we test this with an inspector test?
Comment 3 Timothy Hatcher 2013-06-26 08:43:00 PDT
(In reply to comment #2)
> (From update of attachment 205497 [details])
> Can we test this with an inspector test?

Probably, but the Inspector tests use the old Inspector. We will be redoing that soon to use the new front-end but it will require most tests to be replaced. I'd rather not add new Inspector tests until that happens.
Comment 4 Build Bot 2013-06-26 13:08:02 PDT
Comment on attachment 205497 [details]
Patch

Attachment 205497 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/930508

New failing tests:
inspector/debugger/debugger-script-preprocessor.html
Comment 5 Build Bot 2013-06-26 13:08:03 PDT
Created attachment 205518 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.3
Comment 6 Build Bot 2013-06-26 18:00:06 PDT
Comment on attachment 205497 [details]
Patch

Attachment 205497 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/988028

New failing tests:
inspector/debugger/debugger-script-preprocessor.html
Comment 7 Build Bot 2013-06-26 18:00:09 PDT
Created attachment 205549 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 8 Timothy Hatcher 2013-06-27 04:04:28 PDT
http://trac.webkit.org/changeset/152091