Bug 118061

Summary: [curl] Add "set-cookie" to appendable headers
Product: WebKit Reporter: Szabolcs David <davidsz>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, galpeter, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117300    
Attachments:
Description Flags
Patch
none
Fixed changelog problem none

Description Szabolcs David 2013-06-26 08:19:02 PDT 
The curl implementation does not allows the concatenating of "Set-Cookie" headers. (RFC 2109)
Comment 1 Szabolcs David 2013-06-26 08:22:17 PDT 
Created attachment 205496 [details]
Patch
Comment 2 Peter Gal 2013-06-26 08:57:02 PDT 
(In reply to comment #1)
> Created an attachment (id=205496) [details]
> Patch

Ah... yeah I missed that one in my patch.
Comment 3 Chris Dumez 2013-06-26 10:44:46 PDT 
Comment on attachment 205496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205496&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Please update this line and add a Changelog.
Comment 4 Peter Gal 2013-06-27 01:54:12 PDT 
(In reply to comment #3)
> (From update of attachment 205496 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205496&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests (OOPS!).
> 
> Please update this line and add a Changelog.

The title of the bug already describes the change I don't know what more can be described here.
Comment 5 Gyuyoung Kim 2013-06-27 02:07:33 PDT 
Comment on attachment 205496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205496&action=review

>>> Source/WebCore/ChangeLog:8
>>> +        No new tests (OOPS!).
>> 
>> Please update this line and add a Changelog.
> 
> The title of the bug already describes the change I don't know what more can be described here.

Please read "ChangeLog files" in https://www.webkit.org/coding/contributing.html
Comment 6 Szabolcs David 2013-06-27 02:11:39 PDT 
Created attachment 205578 [details]
Fixed changelog problem
Comment 7 Peter Gal 2013-06-27 02:22:25 PDT 
(In reply to comment #5)
> (From update of attachment 205496 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205496&action=review
> 
> >>> Source/WebCore/ChangeLog:8
> >>> +        No new tests (OOPS!).
> >> 
> >> Please update this line and add a Changelog.
> > 
> > The title of the bug already describes the change I don't know what more can be described here.
> 
> Please read "ChangeLog files" in https://www.webkit.org/coding/contributing.html

I know that, but still... oh well...
Comment 8 Chris Dumez 2013-06-27 02:43:52 PDT 
Comment on attachment 205578 [details]
Fixed changelog problem

Thank you for updating the Changelog. r=me.
Comment 9 WebKit Commit Bot 2013-06-27 03:05:50 PDT 
Comment on attachment 205578 [details]
Fixed changelog problem

Clearing flags on attachment: 205578

Committed r152085: <http://trac.webkit.org/changeset/152085>
Comment 10 WebKit Commit Bot 2013-06-27 03:05:54 PDT 
All reviewed patches have been landed.  Closing bug.