Bug 118041

Summary: RenderBox::hasRenderOverflow should return bool instead of RenderOverflow*
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Layout and RenderingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cdumez, commit-queue, dino, esprehn+autocc, glenn, hyatt, jchaffraix, kling, koivisto, simon.fraser
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup
none
Archive of layout-test-results from APPLE-EWS-5 for win-future none

Ryosuke Niwa
Reported 2013-06-25 23:51:57 PDT
Merge https://chromium.googlesource.com/chromium/blink/+/1683b58c855b745463acbf18086e32279db5000f. It's pretty weird for a function named hasRenderOverflow to return RenderOverflow*.
Attachments
Cleanup (2.96 KB, patch)
2013-06-25 23:53 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from APPLE-EWS-5 for win-future (1.02 MB, application/zip)
2013-06-26 08:33 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-06-25 23:53:04 PDT
Created attachment 205457 [details] Cleanup
Build Bot
Comment 2 2013-06-26 08:33:53 PDT
Comment on attachment 205457 [details] Cleanup Attachment 205457 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/930459 New failing tests: fast/media/mq-transform-03.html fast/forms/search-event-delay.html fast/media/mq-transform-02.html platform/win/accessibility/multiple-select-element-role.html
Build Bot
Comment 3 2013-06-26 08:33:55 PDT
Created attachment 205498 [details] Archive of layout-test-results from APPLE-EWS-5 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: APPLE-EWS-5 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
WebKit Commit Bot
Comment 4 2013-06-26 11:14:01 PDT
Comment on attachment 205457 [details] Cleanup Clearing flags on attachment: 205457 Committed r152002: <http://trac.webkit.org/changeset/152002>
WebKit Commit Bot
Comment 5 2013-06-26 11:14:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.