Bug 118038
| Summary: | HTMLInputElement should lazyAttach on type change | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, jonlee, kling, koivisto |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/39f61bf890997b6117b63de085856d2ff591915b
HTMLInputElement::updateType should use lazyAttach instead of attach and
should schedule the focus appearance update for the future instead of doing
it synchronously. This should make setting the type faster, though we still
create the Shadow DOM subtree which is likely to dominate.
This is another step in getting everyting to lazyAttach.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
rniwa@webkit.org - I looked into it and I think we cannot merge this since HTMLInputElement code has changed significantly and this patch does not have any patch to verify in what issue this is trying to fix.
Can we mark this as "RESOLVED WONTFIX"? Thanks!
Ryosuke Niwa
lazyAttach isn't a thing anymore.