Summary: | Change event should not be dispatched by clicking a scrollbar of select listbox | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||||||||
Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | commit-queue, dino, jonlee, ruthiecftg, tkent, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | BlinkMergeCandidate, InRadar | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Ryosuke Niwa
2013-06-25 20:22:53 PDT
Created attachment 205753 [details]
Patch
Created attachment 205754 [details] test file With patch 205753 alone, I haven't been able to repro the issue of a change event firing after a change event and a change to size of the select list. (I click an option, then the button, and then the scrollbar and can't get the onChange event to fire). Yet, when I run Chromium's layout test, I can hit the case and fail at line 47 with changeEventCounter = 2. (https://chromium.googlesource.com/chromium/blink/+/492549b0fcaa58a85aa0797446b62985a263704f/LayoutTests/fast/forms/select/listbox-click-on-scrollbar.html) Any ideas how to manually repro this situation? (In reply to comment #3) > Yet, when I run Chromium's layout test, I can hit the case and fail at line 47 with changeEventCounter = 2. (https://chromium.googlesource.com/chromium/blink/+/492549b0fcaa58a85aa0797446b62985a263704f/LayoutTests/fast/forms/select/listbox-click-on-scrollbar.html) You need to merge http://src.chromium.org/viewvc/blink?view=revision&revision=152868 too. Created attachment 205841 [details]
Test file to repro size change bug
Created attachment 205843 [details]
Patch
Comment on attachment 205843 [details] Patch Attachment 205843 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1022028 New failing tests: fast/js/global-constructors-attributes-shared-worker.html fast/forms/select/popup-closes-on-blur.html fast/media/mq-transform-03.html editing/selection/user-select-all-image-with-single-click.html fast/forms/search-event-delay.html fast/js/global-constructors-attributes-dedicated-worker.html editing/selection/user-select-all-with-single-click.html fast/media/mq-transform-02.html platform/win/accessibility/multiple-select-element-role.html Created attachment 205947 [details]
Archive of layout-test-results from APPLE-EWS-2 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-2 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Comment on attachment 205843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205843&action=review > Source/WebCore/html/HTMLSelectElement.cpp:1351 > + // This click or drag event was not over any of the options Nit. End the comment with a full-stop/period. Created attachment 205956 [details]
Patch
Comment on attachment 205956 [details] Patch Clearing flags on attachment: 205956 Committed r152330: <http://trac.webkit.org/changeset/152330> All reviewed patches have been landed. Closing bug. *** Bug 117431 has been marked as a duplicate of this bug. *** |