Bug 117994 – Web Inspector: stepping through while paused in debugger makes a popover appear

• Component: Web Inspector
• Status: RESOLVED FIXED

[Antoine Quint]

When paused in the debugger and stepping through the call stack, a popover appears in the content view. I think this is related to a previously highlighted token that we're trying to restore the popover for even though the popover had been dismissed in the meantime.

[Radar WebKit Bug Importer]

<rdar://problem/14260788>

[Antoine Quint]

I'll take a look at this tomorrow.

[Joseph Pecoraro]

Yes, I've noticed this too. I think SourceCodeTextEditor._activeCallFrameDidChange is too keen on reshowing the last tracked token. It should only do that if the popover is visible, to refresh the popover.

[Antoine Quint]

This is due to the following code in SourceCodeTextEditor.prototype._activeCallFrameDidChange:

        if (this.tokenTrackingController.tracking && this.tokenTrackingController.candidate)
            this.tokenTrackingControllerNewHighlightCandidate(this.tokenTrackingController, this.tokenTrackingController.candidate);

[Antoine Quint]

Interestingly this call is directly followed by a call to:

        this._dismissPopover();

But in tokenTrackingControllerNewHighlightCandidate() we display the popover after gathering the content from the backend, so we dismiss and show the popover again.

[Antoine Quint]

Created attachment 205492 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 205492 [details]
Patch

Clearing flags on attachment: 205492

Committed r151991: <http://trac.webkit.org/changeset/151991>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

Stepping through the following code:

    var x = 0;
    x += Math.random();
    x += Math.random();
    x += Math.random();
    x += Math.random();

If I had a popover for "x" and stepped through the code I would want to see the popover stay up and just update with the new value of x each time. Does that happen? Should I just file a separate bug requesting that behavior?

[Antoine Quint]

The popover will hide whenever you step through code and won't reappear until there is additional user action to re-highlight the token. We should indeed have a separate bug to make this work.