Bug 117993

Summary:

SunSpider: Move the 3d-morph fix from version 1.0 to version 1.0.1

Product:

WebKit

Reporter:

Cosmin Truta <ctruta>

Component:

WebKit Website

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, commit-queue, fpizlo, ggaren, rniwa, srikumar.b, staikos

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	fpizlo: review-, fpizlo: commit-queue-
Patch	none

Cosmin Truta

Reported 2013-06-25 08:28:02 PDT

Changeset 149548 was committed without updating the SunSpider 1.0 website. A patch will follow.

Attachments
Patch (1.71 KB, patch) 2013-06-25 08:30 PDT, Cosmin Truta	fpizlo: review- fpizlo: commit-queue-	Details Formatted Diff Diff
Patch (1.85 MB, patch) 2013-07-03 10:46 PDT, Cosmin Truta	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Cosmin Truta

Comment 1 2013-06-25 08:30:48 PDT

Created attachment 205405 [details] Patch

George Staikos

Comment 2 2013-07-03 05:54:23 PDT

Comment on attachment 205405 [details] Patch This makes a lot more sense to me.

Filip Pizlo

Comment 3 2013-07-03 07:28:08 PDT

I think we owe it to the community to do proper versioning here. Please prepare a SunSpider 1.0.1, and make sure that SunSpider 1.0 still has the bug. In fact, I'm shocked that you guys landed the fix in the SunSpider 1.0 directory in the first place - I would revert this. The whole point of having versions is that running a particular version always gives the same results.

Cosmin Truta

Comment 4 2013-07-03 08:44:18 PDT

Changing the bug title to reflect the upcoming work. A patch will follow.

Cosmin Truta

Comment 5 2013-07-03 10:46:34 PDT

Created attachment 206011 [details] Patch So, Filip, we reverted the SunSpider 1.0 change and prepared a new version 1.0.1, as you suggested. I will appreciate your input. Is a public announcement, or other things, needed? We are affected by this issue, so we need to move on and get it fixed.

George Staikos

Comment 6 2013-07-04 16:33:12 PDT

(In reply to comment #3) > I think we owe it to the community to do proper versioning here. Please prepare a SunSpider 1.0.1, and make sure that SunSpider 1.0 still has the bug. In fact, I'm shocked that you guys landed the fix in the SunSpider 1.0 directory in the first place - I would revert this. The whole point of having versions is that running a particular version always gives the same results. I'll leave the new r+ to Filip since it's his request, but really SunSpider 1.0 is broken. This isn't a new version, it's just a fix of the old one.

Srikumar B

Comment 7 2013-07-10 12:26:00 PDT

Filip, Can you review new patch? Its just a kind reminder.

George Staikos

Comment 8 2013-08-07 09:48:53 PDT

Comment on attachment 206011 [details] Patch This seems very reasonable to me.

Cosmin Truta

Comment 9 2013-08-08 09:29:56 PDT

Comment on attachment 206011 [details] Patch Thank you for the review. Committing. By the way, I noticed this change fixes the 3d-morph execution on Windows Phone also.

WebKit Commit Bot

Comment 10 2013-08-08 09:54:13 PDT

Comment on attachment 206011 [details] Patch Clearing flags on attachment: 206011 Committed r153824: <http://trac.webkit.org/changeset/153824>

WebKit Commit Bot

Comment 11 2013-08-08 09:54:16 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.