Bug 117985

Summary: Adopt is/toHTMLAudioElement for code cleanup
Product: WebKit Reporter: Kangil Han <kangil.han>
Component: WebCore Misc.Assignee: Kangil Han <kangil.han>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, buildbot, commit-queue, eric.carlson, esprehn+autocc, glenn, japhet, jer.noble, koivisto, macpherson, menard, rniwa, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kangil Han
Reported 2013-06-25 05:50:52 PDT
Adopt is/toHTMLAudioElement for code cleanup
Attachments
Patch (7.34 KB, patch)
2013-06-25 05:52 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
Patch (10.08 KB, patch)
2013-06-25 18:04 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
Patch (10.35 KB, patch)
2013-06-25 19:08 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kangil Han
Comment 1 2013-06-25 05:52:37 PDT
Created attachment 205389 [details] Patch
Jer Noble
Comment 2 2013-06-25 07:43:37 PDT
Comment on attachment 205389 [details] Patch Looks good in general. There are a couple other places in the code base where we still check <audio> tag names: SubframeLoader.cpp:250, WebPluginController.cpp:502, RenderThemeMac.mm:292,306.
Jer Noble
Comment 3 2013-06-25 07:45:34 PDT
And we should do a follow up bug re: <video> elements as well.
Kangil Han
Comment 4 2013-06-25 18:04:01 PDT
Created attachment 205434 [details] Patch
Kangil Han
Comment 5 2013-06-25 18:06:01 PDT
(In reply to comment #2) > (From update of attachment 205389 [details]) > Looks good in general. There are a couple other places in the code base where we still check <audio> tag names: SubframeLoader.cpp:250, WebPluginController.cpp:502, RenderThemeMac.mm:292,306. Ah, thx! Done. (In reply to comment #3) > And we should do a follow up bug re: <video> elements as well. I will create follow up bugs for all FooElement. :)
Build Bot
Comment 6 2013-06-25 18:28:02 PDT
Comment on attachment 205434 [details] Patch Attachment 205434 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/948299
Jer Noble
Comment 7 2013-06-25 18:35:51 PDT
Comment on attachment 205434 [details] Patch RenderThemeMac.mm may need a #include.
Kangil Han
Comment 8 2013-06-25 19:08:41 PDT
Created attachment 205438 [details] Patch
Kangil Han
Comment 9 2013-06-25 19:09:32 PDT
(In reply to comment #7) > (From update of attachment 205434 [details]) > RenderThemeMac.mm may need a #include. Done. :)
WebKit Commit Bot
Comment 10 2013-06-26 00:44:34 PDT
Comment on attachment 205438 [details] Patch Clearing flags on attachment: 205438 Committed r151981: <http://trac.webkit.org/changeset/151981>
WebKit Commit Bot
Comment 11 2013-06-26 00:44:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.