Bug 117982

Summary:

[BlackBerry] Handle testRunner.setCustomPolicyDelegate()

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

rwlbuis

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	rwlbuis: review+

Description Carlos Garcia Campos 2013-06-25 05:39:33 PDT

It's currently implemented, but the permissive flag is ignored.

Comment 1 Carlos Garcia Campos 2013-06-25 05:47:10 PDT

Created attachment 205386 [details]
Patch

Fixes test fast/loader/onload-policy-ignore-for-frame.html

Comment 2 Rob Buis 2013-06-26 12:43:32 PDT

Comment on attachment 205386 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205386&action=review

LGTM.

> Source/WebKit/blackberry/ChangeLog:8
> +        Take custom cpolicy into account when deciding the policy for

I assume you mean 'policy' here instead of 'cpolicy'.

Comment 3 Carlos Garcia Campos 2013-06-26 23:57:22 PDT

(In reply to comment #2)
> (From update of attachment 205386 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205386&action=review
> 
> LGTM.
> 
> > Source/WebKit/blackberry/ChangeLog:8
> > +        Take custom cpolicy into account when deciding the policy for
> 
> I assume you mean 'policy' here instead of 'cpolicy'.

Oops, yes, it's a typo, will fix it before landing.

Comment 4 Carlos Garcia Campos 2013-06-27 00:00:47 PDT

Committed r152081: <http://trac.webkit.org/changeset/152081>