Bug 117959

Summary:

Fix various crashes on sites with fixed backgrounds

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	aestes: review+

Description Simon Fraser (smfr) 2013-06-24 16:18:08 PDT

Fix various crashes on sites with fixed backgrounds

Comment 1 Simon Fraser (smfr) 2013-06-24 16:21:24 PDT

Created attachment 205341 [details]
Patch

Comment 2 Simon Fraser (smfr) 2013-06-24 16:21:58 PDT

<rdar://problem/14230128>

Comment 3 Andy Estes 2013-06-24 16:25:15 PDT

Comment on attachment 205341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205341&action=review

> Source/WebCore/page/FrameView.cpp:-1566
> -    ASSERT(m_slowRepaintObjects->contains(o));

If we did create a m_slowRepaintObjects, should we not assert that it contains the item we're removing?

Comment 4 Simon Fraser (smfr) 2013-06-24 16:27:16 PDT

(In reply to comment #3)
> If we did create a m_slowRepaintObjects, should we not assert that it contains the item we're removing?

No, it might not contain it.

Comment 5 Simon Fraser (smfr) 2013-06-24 16:27:49 PDT

https://trac.webkit.org/r151934