Bug 117937

Summary: Adopt is/toHTMLFormElement for code cleanup
Product: WebKit Reporter: Kangil Han <kangil.han>
Component: WebCore Misc.Assignee: Kangil Han <kangil.han>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from APPLE-EWS-1 for win-future
none
Patch none

Kangil Han
Reported 2013-06-24 08:51:31 PDT
Adopt is/toHTMLFormElement for code cleanup
Attachments
Patch (27.82 KB, patch)
2013-06-24 09:03 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from APPLE-EWS-1 for win-future (797.89 KB, application/zip)
2013-06-24 12:33 PDT, Build Bot 		no flags
Details
Patch (27.84 KB, patch)
2013-06-24 18:07 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kangil Han
Comment 1 2013-06-24 09:03:37 PDT
Created attachment 205299 [details] Patch
Build Bot
Comment 2 2013-06-24 12:33:04 PDT
Comment on attachment 205299 [details] Patch Attachment 205299 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/953184 New failing tests: media/video-poster-background.html
Build Bot
Comment 3 2013-06-24 12:33:05 PDT
Created attachment 205317 [details] Archive of layout-test-results from APPLE-EWS-1 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: APPLE-EWS-1 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Andreas Kling
Comment 4 2013-06-24 12:37:23 PDT
Comment on attachment 205299 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205299&action=review r=me > Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:601 > - if (toElement(node)->hasTagName(HTMLNames::formTag)) > + if (isHTMLFormElement(toElement(node))) We don't need the toElement() here; isHTMLFormElement() takes a Node*.
Kangil Han
Comment 5 2013-06-24 18:07:11 PDT
Created attachment 205352 [details] Patch
Kangil Han
Comment 6 2013-06-24 18:09:55 PDT
(In reply to comment #4) > > Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:601 > > - if (toElement(node)->hasTagName(HTMLNames::formTag)) > > + if (isHTMLFormElement(toElement(node))) > > We don't need the toElement() here; isHTMLFormElement() takes a Node*. Ah, right! Thx! :) Apply kling's comment to the patch before landing.
WebKit Commit Bot
Comment 7 2013-06-24 19:20:21 PDT
Comment on attachment 205352 [details] Patch Clearing flags on attachment: 205352 Committed r151949: <http://trac.webkit.org/changeset/151949>
WebKit Commit Bot
Comment 8 2013-06-24 19:20:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.