Adopt is/toHTMLFormElement for code cleanup

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Kangil Han]

Adopt is/toHTMLFormElement for code cleanup

[Kangil Han]

Created attachment 205299 [details]
Patch

[Build Bot]

Comment on attachment 205299 [details]
Patch

Attachment 205299 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/953184

New failing tests:
media/video-poster-background.html

[Build Bot]

Created attachment 205317 [details]
Archive of layout-test-results from APPLE-EWS-1 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-1  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

[Andreas Kling]

Comment on attachment 205299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205299&action=review

r=me

> Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:601
> -        if (toElement(node)->hasTagName(HTMLNames::formTag))
> +        if (isHTMLFormElement(toElement(node)))

We don't need the toElement() here; isHTMLFormElement() takes a Node*.

[Kangil Han]

Created attachment 205352 [details]
Patch

[Kangil Han]

(In reply to comment #4)
> > Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:601
> > -        if (toElement(node)->hasTagName(HTMLNames::formTag))
> > +        if (isHTMLFormElement(toElement(node)))
> 
> We don't need the toElement() here; isHTMLFormElement() takes a Node*.

Ah, right! Thx! :)
Apply kling's comment to the patch before landing.

[WebKit Commit Bot]

Comment on attachment 205352 [details]
Patch

Clearing flags on attachment: 205352

Committed r151949: <http://trac.webkit.org/changeset/151949>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.