Bug 117903

Summary: Crashes due to NULL dereference beneath WebCore::StyleResolver::loadPendingSVGDocuments and related functions
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: CSSAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, esprehn+autocc, fengle.takeiteasy, glenn, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Geoffrey Garen 2013-06-21 18:19:31 PDT 
Crashes due to NULL dereference beneath WebCore::StyleResolver::loadPendingSVGDocuments and related functions
Comment 1 Geoffrey Garen 2013-06-21 18:20:35 PDT 
Created attachment 205230 [details]
Patch
Comment 2 WebKit Commit Bot 2013-06-21 18:22:23 PDT 
Attachment 205230 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/StyleResolver.cpp']" exit_code: 1
Source/WebCore/css/StyleResolver.cpp:3567:  Use 0 or null instead of NULL (even in *comments*).  [readability/null] [4]
Source/WebCore/css/StyleResolver.cpp:4204:  Use 0 or null instead of NULL (even in *comments*).  [readability/null] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2013-06-21 19:36:40 PDT 
Comment on attachment 205230 [details]
Patch

Clearing flags on attachment: 205230

Committed r151875: <http://trac.webkit.org/changeset/151875>
Comment 4 WebKit Commit Bot 2013-06-21 19:36:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Geoffrey Garen 2013-06-24 09:39:34 PDT 
<rdar://problem/14202130>
Comment 6 fengleli 2013-07-24 04:38:40 PDT 
the Fixed method just check if style() is NULL,could you tell me,when the style is NULL,I need some test case to reappear the crash.