Bug 117903

Summary: Crashes due to NULL dereference beneath WebCore::StyleResolver::loadPendingSVGDocuments and related functions
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: CSSAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, esprehn+autocc, fengle.takeiteasy, glenn, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Geoffrey Garen
Reported 2013-06-21 18:19:31 PDT
Crashes due to NULL dereference beneath WebCore::StyleResolver::loadPendingSVGDocuments and related functions
Attachments
Patch (2.11 KB, patch)
2013-06-21 18:20 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2013-06-21 18:20:35 PDT
Created attachment 205230 [details] Patch
WebKit Commit Bot
Comment 2 2013-06-21 18:22:23 PDT
Attachment 205230 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/StyleResolver.cpp']" exit_code: 1 Source/WebCore/css/StyleResolver.cpp:3567: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] Source/WebCore/css/StyleResolver.cpp:4204: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2013-06-21 19:36:40 PDT
Comment on attachment 205230 [details] Patch Clearing flags on attachment: 205230 Committed r151875: <http://trac.webkit.org/changeset/151875>
WebKit Commit Bot
Comment 4 2013-06-21 19:36:42 PDT
All reviewed patches have been landed. Closing bug.
Geoffrey Garen
Comment 5 2013-06-24 09:39:34 PDT
<rdar://problem/14202130>
fengleli
Comment 6 2013-07-24 04:38:40 PDT
the Fixed method just check if style() is NULL,could you tell me,when the style is NULL,I need some test case to reappear the crash.
Note You need to log in before you can comment on or make changes to this bug.