Bug 117879
Summary: | REGRESSION (r151755-r151757): fast/forms/search-event-delay.html failing on Apple Win 7 Release (Tests) | ||
---|---|---|---|
Product: | WebKit | Reporter: | Roger Fong <roger_fong> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED CONFIGURATION CHANGED | ||
Severity: | Normal | CC: | ahmad.saleem792, bfulgham, roger_fong, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar, LayoutTestFailure, MakingBotsRed, Regression |
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
URL: | http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r151757%20(36690)/results.html |
Roger Fong
fast/forms/search-event-delay.html started failing on Apple Win 7 Release (Tests) between r151756 and r151757 (inclusive).
http://trac.webkit.org/log/trunk?rev=151757&stop_rev=151756&limit=3
http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r151755%20(36689)/results.html passed
http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r151757%20(36690)/results.html failed
This regressed r151756.
Upon doing some more research into the issue, Window's currentTime implementation returns the system time.
We want number of seconds since epoch, the time() function would do the trick.
However, reverting the change on win to use GetTickCount() (definitely not the time since epoch) causes the test to pass again and using time() just causes it to fail differently.
So something else down the code path is processing the time returned by current time incorrectly.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
This test is gone - post - https://commits.webkit.org/266068@main