Bug 117866

Summary: [GTK] Do not try to load videos in unit tests
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gustavo, mrobinson, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch pnormand: review+

Description Carlos Garcia Campos 2013-06-21 01:21:40 PDT
It makes the tests slower, and generates and error because we use a fake src.

/webkit2/WebKitWebView/default-context: OK
/webkit2/WebKitWebView/custom-charset: OK
/webkit2/WebKitWebView/settings: OK
/webkit2/WebKitWebView/create-ready-close: OK
/webkit2/WebKitWebView/allow-modal-dialogs: OK
/webkit2/WebKitWebView/disallow-modal-dialogs: OK
/webkit2/WebKitWebView/javascript-dialogs: OK
/webkit2/WebKitWebView/window-properties: OK
/webkit2/WebKitWebView/mouse-target: 0:00:00.145337568 15565  0x998fee0 ERROR      webkitmediaplayer ../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:733:handleMessage: Error 3: Resource not found. (url=file:///movie.ogg)
0:00:00.145576435 15565  0x998fee0 ERROR      webkitmediaplayer ../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:733:handleMessage: Error 3: Resource not found. (url=file:///movie.ogg)
OK
/webkit2/WebKitWebView/permission-requests: OK
/webkit2/WebKitWebView/zoom-level: OK
/webkit2/WebKitWebView/run-javascript: OK
/webkit2/WebKitWebView/file-chooser-request: OK
/webkit2/WebKitWebView/fullscreen: OK
/webkit2/WebKitWebView/can-show-mime-type: OK
/webkit2/WebKitWebView/submit-form: OK
Comment 1 Carlos Garcia Campos 2013-06-21 01:23:24 PDT
Created attachment 205157 [details]
Patch
Comment 2 WebKit Commit Bot 2013-06-21 01:24:20 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2013-06-21 04:42:16 PDT
Committed r151833: <http://trac.webkit.org/changeset/151833>