Bug 11786

Summary: Create ResourceHandleBase to eliminate #ifdefs in ResourceHandle and related headers
Product: WebKit Reporter: Darin Fisher (:fishd, Google) <fishd>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: ASSIGNED    
Severity: Minor CC: ap, beidson
Priority: P3    
Version: 420+   
Hardware: PC   
OS: All   
Attachments:
Description Flags
prototype patch for PLATFORM(MAC) only none

Darin Fisher (:fishd, Google)
Reported 2006-12-08 12:58:20 PST
Refactor ResourceHandleInternal to ease porting Currently it is necessary to #ifdef ResourceHandleInternal when implementing a port of ResourceHandle. It'd be a lot simpler if ResourceHandlerInternal were a base class that only defined the shared member variables. Then each port could subclass that to define their port specific member variables, and each port could be responsible for allocating ResourceHandle's d-pointer. If such a change is acceptable, I'll gladly cut a patch.
Attachments
prototype patch for PLATFORM(MAC) only (71.83 KB, patch)
2008-01-24 23:37 PST, Darin Fisher (:fishd, Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2008-01-24 23:28:19 PST
I'd like to reframe this bug in terms of creating ResourceHandleBase, which would allow us to eliminate ResourceHandleInternal and avoid a bunch of platform #ifdefs.
Darin Fisher (:fishd, Google)
Comment 2 2008-01-24 23:37:54 PST
Created attachment 18687 [details] prototype patch for PLATFORM(MAC) only Here's the initial changes for PLATFORM(MAC). I'd like feedback on this approach before I make corresponding changes for the other platforms :-)
Darin Fisher (:fishd, Google)
Comment 3 2008-01-25 13:00:00 PST
Comment on attachment 18687 [details] prototype patch for PLATFORM(MAC) only actually, this isn't ready for review yet.
Note You need to log in before you can comment on or make changes to this bug.