Bug 117835

Summary: [CSS Regions] Move overset compute code from flow thread to named flow thread
Product: WebKit Reporter: Radu Stavila <stavila>
Component: CSSAssignee: Radu Stavila <stavila>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, mihnea, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Patch
kling: review+, stavila: commit-queue?
Patch (included changes requested by Kling) none

Description Radu Stavila 2013-06-20 07:03:22 PDT
[CSS Regions] Move overset compute code from flow thread to named flow thread
Comment 1 Radu Stavila 2013-06-21 08:33:20 PDT
Created attachment 205187 [details]
Patch
Comment 2 Andreas Kling 2013-06-21 08:52:13 PDT
Comment on attachment 205187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205187&action=review

r=me with a suggestion:

> Source/WebCore/rendering/RenderRegion.cpp:136
> +    ASSERT(node() && node()->isElementNode());

Maybe we could add an element() helper, to avoid having to check/cast all the time.

> Source/WebCore/rendering/RenderRegion.cpp:146
> +    ASSERT(node() && node()->isElementNode());

etc.
Comment 3 Radu Stavila 2013-06-21 09:11:37 PDT
Created attachment 205190 [details]
Patch (included changes requested by Kling)
Comment 4 WebKit Commit Bot 2013-06-21 10:43:18 PDT
Comment on attachment 205190 [details]
Patch (included changes requested by Kling)

Clearing flags on attachment: 205190

Committed r151843: <http://trac.webkit.org/changeset/151843>