Bug 117829

Summary:

Cleanup usage of CSSPropertyID and CSSValueID inside WebKit.

Product:

WebKit

Reporter:

Alexis Menard (darktears) <menard>

Component:

CSS

Assignee:

Alexis Menard (darktears) <menard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eflews.bot, gyuyoung.kim, kling, koivisto

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

117936

Attachments:

Description	Flags
Patch	none
fix build	none
Patch	none
Patch for landing	none

Alexis Menard (darktears)

Reported 2013-06-20 05:41:53 PDT

Cleanup usage of CSSPropertyID and CSSValueID inside WebKit.

Attachments
Patch (312.43 KB, patch) 2013-06-20 05:46 PDT, Alexis Menard (darktears)	no flags	Details Formatted Diff Diff
fix build (320.58 KB, patch) 2013-06-20 07:02 PDT, Alexis Menard (darktears)	no flags	Details Formatted Diff Diff
Patch (320.56 KB, patch) 2013-06-20 09:35 PDT, Alexis Menard (darktears)	no flags	Details Formatted Diff Diff
Patch for landing (320.69 KB, patch) 2013-06-20 10:15 PDT, Alexis Menard (darktears)	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alexis Menard (darktears)

Comment 1 2013-06-20 05:46:31 PDT

Created attachment 205077 [details] Patch

WebKit Commit Bot

Comment 2 2013-06-20 05:49:13 PDT

Attachment 205077 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/CSSGradientValue.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSParser.h', u'Source/WebCore/css/CSSParserValues.cpp', u'Source/WebCore/css/CSSPrimitiveValue.cpp', u'Source/WebCore/css/CSSPrimitiveValue.h', u'Source/WebCore/css/CSSPrimitiveValueMappings.h', u'Source/WebCore/css/CSSToStyleMap.cpp', u'Source/WebCore/css/Counter.h', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/css/SVGCSSParser.cpp', u'Source/WebCore/css/SVGCSSStyleSelector.cpp', u'Source/WebCore/css/StylePropertySet.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/ViewportStyleResolver.cpp', u'Source/WebCore/css/WebKitCSSMatrix.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/EditingStyle.h', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk.h', u'Source/WebCore/platform/gtk/RenderThemeGtk2.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk3.cpp', u'Source/WebCore/platform/qt/RenderThemeQt.cpp', u'Source/WebCore/platform/qt/RenderThemeQt.h', u'Source/WebCore/rendering/RenderTheme.cpp', u'Source/WebCore/rendering/RenderTheme.h', u'Source/WebCore/rendering/RenderThemeMac.h', u'Source/WebCore/rendering/RenderThemeMac.mm', u'Source/WebCore/rendering/RenderThemeWin.cpp', u'Source/WebCore/rendering/RenderThemeWin.h', u'Source/WebCore/rendering/RenderThemeWinCE.cpp', u'Source/WebCore/rendering/RenderThemeWinCE.h']" exit_code: 1 Source/WebCore/css/CSSPrimitiveValue.h:139: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/css/CSSPrimitiveValue.h:140: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 2 in 38 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alexis Menard (darktears)

Comment 3 2013-06-20 05:51:33 PDT

(In reply to comment #2) > Attachment 205077 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/CSSGradientValue.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSParser.h', u'Source/WebCore/css/CSSParserValues.cpp', u'Source/WebCore/css/CSSPrimitiveValue.cpp', u'Source/WebCore/css/CSSPrimitiveValue.h', u'Source/WebCore/css/CSSPrimitiveValueMappings.h', u'Source/WebCore/css/CSSToStyleMap.cpp', u'Source/WebCore/css/Counter.h', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/css/SVGCSSParser.cpp', u'Source/WebCore/css/SVGCSSStyleSelector.cpp', u'Source/WebCore/css/StylePropertySet.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/ViewportStyleResolver.cpp', u'Source/WebCore/css/WebKitCSSMatrix.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/EditingStyle.h', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk.h', u'Source/WebCore/platform/gtk/RenderThemeGtk2.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk3.cpp', u'Source/WebCore/platform/qt/RenderThemeQt.cpp', u'Source/WebCore/platform/qt/RenderThemeQt.h', u'Source/WebCore/rendering/RenderTheme.cpp', u'Source/WebCore/rendering/RenderTheme.h', u'Source/WebCore/rendering/RenderThemeMac.h', u'Source/WebCore/rendering/RenderThemeMac.mm', u'Source/WebCore/rendering/RenderThemeWin.cpp', u'Source/WebCore/rendering/RenderThemeWin.h', u'Source/WebCore/rendering/RenderThemeWinCE.cpp', u'Source/WebCore/rendering/RenderThemeWinCE.h']" exit_code: 1 > Source/WebCore/css/CSSPrimitiveValue.h:139: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] > Source/WebCore/css/CSSPrimitiveValue.h:140: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] > Total errors found: 2 in 38 files > > Please ignore, I'm following the current style. In the future we should change them but some of the values are exposed in JS. > If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 4 2013-06-20 06:13:14 PDT

Comment on attachment 205077 [details] Patch Attachment 205077 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/923822

EFL EWS Bot

Comment 5 2013-06-20 06:21:37 PDT

Comment on attachment 205077 [details] Patch Attachment 205077 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/895884

Alexis Menard (darktears)

Comment 6 2013-06-20 07:02:02 PDT

Created attachment 205088 [details] fix build

WebKit Commit Bot

Comment 7 2013-06-20 07:03:45 PDT

Attachment 205088 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/CSSGradientValue.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSParser.h', u'Source/WebCore/css/CSSParserValues.cpp', u'Source/WebCore/css/CSSPrimitiveValue.cpp', u'Source/WebCore/css/CSSPrimitiveValue.h', u'Source/WebCore/css/CSSPrimitiveValueMappings.h', u'Source/WebCore/css/CSSToStyleMap.cpp', u'Source/WebCore/css/Counter.h', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/css/SVGCSSParser.cpp', u'Source/WebCore/css/SVGCSSStyleSelector.cpp', u'Source/WebCore/css/StylePropertySet.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/ViewportStyleResolver.cpp', u'Source/WebCore/css/WebKitCSSMatrix.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/EditingStyle.h', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp', u'Source/WebCore/platform/blackberry/RenderThemeBlackBerry.h', u'Source/WebCore/platform/efl/RenderThemeEfl.cpp', u'Source/WebCore/platform/efl/RenderThemeEfl.h', u'Source/WebCore/platform/gtk/RenderThemeGtk.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk.h', u'Source/WebCore/platform/gtk/RenderThemeGtk2.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk3.cpp', u'Source/WebCore/platform/qt/RenderThemeQt.cpp', u'Source/WebCore/platform/qt/RenderThemeQt.h', u'Source/WebCore/rendering/RenderTheme.cpp', u'Source/WebCore/rendering/RenderTheme.h', u'Source/WebCore/rendering/RenderThemeMac.h', u'Source/WebCore/rendering/RenderThemeMac.mm', u'Source/WebCore/rendering/RenderThemeSafari.cpp', u'Source/WebCore/rendering/RenderThemeSafari.h', u'Source/WebCore/rendering/RenderThemeWin.cpp', u'Source/WebCore/rendering/RenderThemeWin.h', u'Source/WebCore/rendering/RenderThemeWinCE.cpp', u'Source/WebCore/rendering/RenderThemeWinCE.h']" exit_code: 1 Source/WebCore/css/CSSPrimitiveValue.h:139: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/css/CSSPrimitiveValue.h:140: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 2 in 44 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alexis Menard (darktears)

Comment 8 2013-06-20 09:35:10 PDT

Created attachment 205099 [details] Patch

WebKit Commit Bot

Comment 9 2013-06-20 09:38:29 PDT

Attachment 205099 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/CSSGradientValue.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSParser.h', u'Source/WebCore/css/CSSParserValues.cpp', u'Source/WebCore/css/CSSPrimitiveValue.cpp', u'Source/WebCore/css/CSSPrimitiveValue.h', u'Source/WebCore/css/CSSPrimitiveValueMappings.h', u'Source/WebCore/css/CSSToStyleMap.cpp', u'Source/WebCore/css/Counter.h', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/css/SVGCSSParser.cpp', u'Source/WebCore/css/SVGCSSStyleSelector.cpp', u'Source/WebCore/css/StylePropertySet.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/ViewportStyleResolver.cpp', u'Source/WebCore/css/WebKitCSSMatrix.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/EditingStyle.h', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp', u'Source/WebCore/platform/blackberry/RenderThemeBlackBerry.h', u'Source/WebCore/platform/efl/RenderThemeEfl.cpp', u'Source/WebCore/platform/efl/RenderThemeEfl.h', u'Source/WebCore/platform/gtk/RenderThemeGtk.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk.h', u'Source/WebCore/platform/gtk/RenderThemeGtk2.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk3.cpp', u'Source/WebCore/platform/qt/RenderThemeQt.cpp', u'Source/WebCore/platform/qt/RenderThemeQt.h', u'Source/WebCore/rendering/RenderTheme.cpp', u'Source/WebCore/rendering/RenderTheme.h', u'Source/WebCore/rendering/RenderThemeMac.h', u'Source/WebCore/rendering/RenderThemeMac.mm', u'Source/WebCore/rendering/RenderThemeSafari.cpp', u'Source/WebCore/rendering/RenderThemeSafari.h', u'Source/WebCore/rendering/RenderThemeWin.cpp', u'Source/WebCore/rendering/RenderThemeWin.h', u'Source/WebCore/rendering/RenderThemeWinCE.cpp', u'Source/WebCore/rendering/RenderThemeWinCE.h']" exit_code: 1 Source/WebCore/css/CSSPrimitiveValue.h:139: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/css/CSSPrimitiveValue.h:140: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 2 in 44 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 10 2013-06-20 10:11:46 PDT

Comment on attachment 205099 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205099&action=review This is a great change! r=me, assuming EWS flips green. > Source/WebCore/ChangeLog:9 > + not incorrect per say, it's not ideal for various reason such as type per say => per se > Source/WebCore/css/CSSParserValues.cpp:75 > return primitiveValue; Unrelated: Missing .release() here.

Alexis Menard (darktears)

Comment 11 2013-06-20 10:15:04 PDT

Created attachment 205102 [details] Patch for landing

WebKit Commit Bot

Comment 12 2013-06-20 10:16:52 PDT

Attachment 205102 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/CSSGradientValue.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSParser.h', u'Source/WebCore/css/CSSParserValues.cpp', u'Source/WebCore/css/CSSPrimitiveValue.cpp', u'Source/WebCore/css/CSSPrimitiveValue.h', u'Source/WebCore/css/CSSPrimitiveValueMappings.h', u'Source/WebCore/css/CSSToStyleMap.cpp', u'Source/WebCore/css/Counter.h', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/css/SVGCSSParser.cpp', u'Source/WebCore/css/SVGCSSStyleSelector.cpp', u'Source/WebCore/css/StylePropertySet.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/ViewportStyleResolver.cpp', u'Source/WebCore/css/WebKitCSSMatrix.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/EditingStyle.h', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp', u'Source/WebCore/platform/blackberry/RenderThemeBlackBerry.h', u'Source/WebCore/platform/efl/RenderThemeEfl.cpp', u'Source/WebCore/platform/efl/RenderThemeEfl.h', u'Source/WebCore/platform/gtk/RenderThemeGtk.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk.h', u'Source/WebCore/platform/gtk/RenderThemeGtk2.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk3.cpp', u'Source/WebCore/platform/qt/RenderThemeQt.cpp', u'Source/WebCore/platform/qt/RenderThemeQt.h', u'Source/WebCore/rendering/RenderTheme.cpp', u'Source/WebCore/rendering/RenderTheme.h', u'Source/WebCore/rendering/RenderThemeMac.h', u'Source/WebCore/rendering/RenderThemeMac.mm', u'Source/WebCore/rendering/RenderThemeSafari.cpp', u'Source/WebCore/rendering/RenderThemeSafari.h', u'Source/WebCore/rendering/RenderThemeWin.cpp', u'Source/WebCore/rendering/RenderThemeWin.h', u'Source/WebCore/rendering/RenderThemeWinCE.cpp', u'Source/WebCore/rendering/RenderThemeWinCE.h']" exit_code: 1 Source/WebCore/css/CSSPrimitiveValue.h:139: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/css/CSSPrimitiveValue.h:140: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 2 in 44 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 13 2013-06-20 11:05:18 PDT

Comment on attachment 205102 [details] Patch for landing Clearing flags on attachment: 205102 Committed r151783: <http://trac.webkit.org/changeset/151783>

WebKit Commit Bot

Comment 14 2013-06-20 11:05:21 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.