Bug 117827

Summary: [BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rwlbuis, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Updated patch none

Carlos Garcia Campos
Reported 2013-06-20 05:14:40 PDT
It's not currently handled making some tests that use it fail.
Attachments
Patch (5.80 KB, patch)
2013-06-20 05:21 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch (5.72 KB, patch)
2013-06-20 09:07 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-06-20 05:21:17 PDT
Created attachment 205074 [details] Patch
Rob Buis
Comment 2 2013-06-20 07:46:45 PDT
Comment on attachment 205074 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205074&action=review > Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:630 > + } Could this method just return bool? Is it possible for request to be null coming in? Also if the above two blocks can be combined you don't need the return.
Carlos Garcia Campos
Comment 3 2013-06-20 09:07:34 PDT
Created attachment 205097 [details] Updated patch
Rob Buis
Comment 4 2013-06-20 09:09:32 PDT
Comment on attachment 205097 [details] Updated patch LGTM.
WebKit Commit Bot
Comment 5 2013-06-20 10:14:56 PDT
Comment on attachment 205097 [details] Updated patch Clearing flags on attachment: 205097 Committed r151780: <http://trac.webkit.org/changeset/151780>
WebKit Commit Bot
Comment 6 2013-06-20 10:14:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.