Bug 117827

Summary: [BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rwlbuis, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Updated patch none

Description Carlos Garcia Campos 2013-06-20 05:14:40 PDT 
It's not currently handled making some tests that use it fail.
Comment 1 Carlos Garcia Campos 2013-06-20 05:21:17 PDT 
Created attachment 205074 [details]
Patch
Comment 2 Rob Buis 2013-06-20 07:46:45 PDT 
Comment on attachment 205074 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205074&action=review

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:630
> +    }

Could this method just return bool? Is it possible for request to be null coming in? Also if the above two blocks can be combined you don't need the return.
Comment 3 Carlos Garcia Campos 2013-06-20 09:07:34 PDT 
Created attachment 205097 [details]
Updated patch
Comment 4 Rob Buis 2013-06-20 09:09:32 PDT 
Comment on attachment 205097 [details]
Updated patch

LGTM.
Comment 5 WebKit Commit Bot 2013-06-20 10:14:56 PDT 
Comment on attachment 205097 [details]
Updated patch

Clearing flags on attachment: 205097

Committed r151780: <http://trac.webkit.org/changeset/151780>
Comment 6 WebKit Commit Bot 2013-06-20 10:14:58 PDT 
All reviewed patches have been landed.  Closing bug.