Bug 117818

Summary: [Mac] Downloaded file name encoding is incorrect when download link opens in a new window
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Page LoadingAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, japhet
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix beidson: review+

Alexey Proskuryakov
Reported 2013-06-19 21:23:48 PDT
We set up downloaded file name encoding via FrameLoader::addExtraFieldsToRequest(), and one of the options is referring document's encoding. But FrameLoader::addExtraFieldsToRequest() is called at poorly defined times, one of which is after policy delegate. If the download link is target="_blank", then this happens after a new tab opens, and we overwrite a perfectly good fallback encoding array with one from a blank document. <rdar://problem/14212635>
Attachments
proposed fix (2.47 KB, patch)
2013-06-19 22:08 PDT, Alexey Proskuryakov 		beidson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-06-19 22:08:01 PDT
Created attachment 205056 [details] proposed fix
Brady Eidson
Comment 2 2013-06-20 12:42:37 PDT
Comment on attachment 205056 [details] proposed fix This code is gross. This fix is good for this bug, though.
Alexey Proskuryakov
Comment 3 2013-06-20 13:06:36 PDT
Committed <http://trac.webkit.org/r151793>.
Note You need to log in before you can comment on or make changes to this bug.