Bug 117810

Summary:

Web Inspector: Use console.timeStamp instead of console.markTimeline

Product:

WebKit

Reporter:

Seokju Kwon <seokju>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, divya, esprehn+autocc, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Seokju Kwon

Reported 2013-06-19 15:56:15 PDT

It seems like 'console.markTimeline' is deprecated. Use the console.timeStamp instead.

Attachments
Patch (5.07 KB, patch) 2013-06-19 15:58 PDT, Seokju Kwon	no flags	Details Formatted Diff Diff
Patch (9.30 KB, patch) 2013-06-19 17:53 PDT, Seokju Kwon	no flags	Details Formatted Diff Diff
Patch (9.31 KB, patch) 2013-06-19 20:58 PDT, Seokju Kwon	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2013-06-19 15:56:26 PDT

<rdar://problem/14209720>

Seokju Kwon

Comment 2 2013-06-19 15:58:36 PDT

Created attachment 205036 [details] Patch

Joseph Pecoraro

Comment 3 2013-06-19 16:27:02 PDT

Comment on attachment 205036 [details] Patch If you're going this far to remove tests for it, you might as well remove support for it entirely. Thoughts? See: <http://webkit.org/b/117720> Web Inspector: Rename console.markTimeline to console.timeStamp

Seokju Kwon

Comment 4 2013-06-19 17:04:59 PDT

(In reply to comment #3) > (From update of attachment 205036 [details]) > If you're going this far to remove tests for it, you might as well remove support for it entirely. Thoughts? > > See: <http://webkit.org/b/117720> Web Inspector: Rename console.markTimeline to console.timeStamp Sure. I will remove "console.markTimeline" on a next patch. Thanks, Joseph Pecoraro.

Seokju Kwon

Comment 5 2013-06-19 17:53:57 PDT

Created attachment 205046 [details] Patch

Joseph Pecoraro

Comment 6 2013-06-19 20:53:31 PDT

Comment on attachment 205046 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205046&action=review Thanks! r=me > LayoutTests/ChangeLog:8 > + Use 'console.timeStamp' instead of 'console.markTimeline' in Layouttest. Typo: "Layouttest" => "LayoutTests"

Joseph Pecoraro

Comment 7 2013-06-19 20:54:20 PDT

*** Bug 117720 has been marked as a duplicate of this bug. ***

Seokju Kwon

Comment 8 2013-06-19 20:58:26 PDT

Created attachment 205051 [details] Patch

Seokju Kwon

Comment 9 2013-06-19 20:59:16 PDT

(In reply to comment #6) > (From update of attachment 205046 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205046&action=review > > Thanks! r=me > > > LayoutTests/ChangeLog:8 > > + Use 'console.timeStamp' instead of 'console.markTimeline' in Layouttest. > > Typo: "Layouttest" => "LayoutTests" Fixed it. Thanks :)

Joseph Pecoraro

Comment 10 2013-06-19 21:47:08 PDT

Let me know if you still need me to cq+.

Seokju Kwon

Comment 11 2013-06-19 22:08:22 PDT

(In reply to comment #10) > Let me know if you still need me to cq+. Cool. Could you cq+ for this patch? Thanks in advance for your help. :D

WebKit Commit Bot

Comment 12 2013-06-20 06:22:17 PDT

Comment on attachment 205051 [details] Patch Clearing flags on attachment: 205051 Committed r151774: <http://trac.webkit.org/changeset/151774>

WebKit Commit Bot

Comment 13 2013-06-20 06:22:21 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.