Bug 117808

Summary: Remove the SegmentedVector inline segment to shrink CodeBlock by 6X
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, k.gurpreet, oliver, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Description Geoffrey Garen 2013-06-19 15:20:51 PDT 
Remove the SegmentedVector inline segment to shrink CodeBlock by 6X
Comment 1 Geoffrey Garen 2013-06-19 15:25:49 PDT 
Created attachment 205033 [details]
Patch
Comment 2 Geoffrey Garen 2013-06-19 15:26:14 PDT 
Comment on attachment 205033 [details]
Patch

Oliver Hunt reviewed this.
Comment 3 Radar WebKit Bug Importer 2013-06-19 15:26:38 PDT 
<rdar://problem/14209227>
Comment 4 Geoffrey Garen 2013-06-19 15:29:34 PDT 
Committed revision <http://trac.webkit.org/changeset/151755>.
Comment 5 Gurpreet 2014-06-17 07:20:20 PDT 
Hi Geoffrey. I have few doubts regarding this patch. I merged this patch to my old webkit version but did not see any improvement in peak memory.

1) Does it reduce peak memory?
2) If not then how can we quantify the CodeBlock memory targeted by the patch?
3) Is there any other live site other than google where this can be verified?
4) Can it applied on rev 124*(series) and would that show any improvement?

Thanks.