Bug 117769

Summary: Consider removing -webkit-marquee
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: CSSAssignee: Emilio Cobos Álvarez (:emilio) <emilio>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, dino, emilio, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, koivisto, macpherson, menard, mmaxfield, simon.fraser, syoichi, webkit-bug-importer
Priority: P2 Keywords: BlinkMergeCandidate, InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Ryosuke Niwa
Reported 2013-06-18 19:40:12 PDT
Removing this CSS property will allow us simplifying render layers as done in: https://chromium.googlesource.com/chromium/blink/+/d67412c398c2ac375a701b7a5b0da61e85d568e1 Blink has already done that so we should consider doing the same.
Attachments
Patch (19.62 KB, patch)
2019-12-14 19:37 PST, Emilio Cobos Álvarez (:emilio) 		no flags
DetailsFormatted DiffDiff
Patch (51.45 KB, patch)
2019-12-15 05:23 PST, Emilio Cobos Álvarez (:emilio) 		no flags
DetailsFormatted DiffDiff
Patch for landing (51.51 KB, patch)
2019-12-15 11:34 PST, Emilio Cobos Álvarez (:emilio) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Emilio Cobos Álvarez (:emilio)
Comment 1 2019-12-14 19:37:43 PST
Created attachment 385704 [details] Patch
Emilio Cobos Álvarez (:emilio)
Comment 2 2019-12-14 19:38:55 PST
Comment on attachment 385704 [details] Patch For EWS only for now, as I guess I'd have to update a bunch of other tests...
Ryosuke Niwa
Comment 3 2019-12-14 23:53:27 PST
Seems like a good idea.
Antti Koivisto
Comment 4 2019-12-15 00:16:01 PST
Someone should also reimplement <marquee> as some sort shadow dom/web animation thing. Would be a fun exercise.
Emilio Cobos Álvarez (:emilio)
Comment 5 2019-12-15 05:23:24 PST
Created attachment 385710 [details] Patch
Emilio Cobos Álvarez (:emilio)
Comment 6 2019-12-15 05:36:28 PST
(In reply to Antti Koivisto from comment #4) > Someone should also reimplement <marquee> as some sort shadow dom/web > animation thing. Would be a fun exercise. That does sound fun, though it is unfortunately a bit out of the scope I can dedicate to hacking on WebKit on my free time :P
Emilio Cobos Álvarez (:emilio)
Comment 7 2019-12-15 06:44:57 PST
Ok, looks ok on EWS now. There is some orange but it seems unrelated to this change.
Simon Fraser (smfr)
Comment 8 2019-12-15 09:58:59 PST
(In reply to Ryosuke Niwa from comment #0) > Removing this CSS property will allow us simplifying render layers as done > in: > https://chromium.googlesource.com/chromium/blink/+/ > d67412c398c2ac375a701b7a5b0da61e85d568e1 > > Blink has already done that so we should consider doing the same. Yeah, it's crazy that RenderMarquee isn't a RenderObject.
WebKit Commit Bot
Comment 9 2019-12-15 10:44:29 PST
Comment on attachment 385710 [details] Patch Rejecting attachment 385710 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 385710, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebInspectorUI/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/13291886
Emilio Cobos Álvarez (:emilio)
Comment 10 2019-12-15 11:34:19 PST
Created attachment 385724 [details] Patch for landing
WebKit Commit Bot
Comment 11 2019-12-15 12:19:15 PST
Comment on attachment 385724 [details] Patch for landing Clearing flags on attachment: 385724 Committed r253540: <https://trac.webkit.org/changeset/253540>
WebKit Commit Bot
Comment 12 2019-12-15 12:19:17 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2019-12-15 12:20:19 PST
<rdar://problem/57950473>
Note You need to log in before you can comment on or make changes to this bug.