Summary: | Web Inspector: Infrequent uncaught exception with debugger popovers breaks inspector | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2013-06-18 14:23:43 PDT
Doing a quick search through the code base, ZERO_SIZE and ZERO_RECT were the only 2 objects being initialized before we reassigned the prototype. There were only a few other objects, all safe. shell> ack '^WebInsp.*?= new' Geometry.js 87:WebInspector.Size.ZERO_SIZE = new WebInspector.Size(0, 0); 178:WebInspector.Rect.ZERO_RECT = new WebInspector.Rect(0, 0, 0, 0); Object.js 235:WebInspector.notifications = new WebInspector.Object; Popover.js 56:WebInspector.Popover.AnchorSize = new WebInspector.Size(22, 11); 57:WebInspector.Popover.ShadowEdgeInsets = new WebInspector.EdgeInsets(WebInspector.Popover.ShadowPadding); Also the only non-WebInspector namespaced object (InspectorBackend) was correct. Created attachment 204948 [details]
[PATCH] Proposed Fix
Comment on attachment 204948 [details] [PATCH] Proposed Fix Clearing flags on attachment: 204948 Committed r151704: <http://trac.webkit.org/changeset/151704> All reviewed patches have been landed. Closing bug. |