Bug 117748

Summary:

WaveTable name has changed to PeriodicWave

Product:

WebKit

Reporter:

Chris Rogers <crogers>

Component:

Web Audio

Assignee:

Chris Rogers <crogers>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, crogers, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, rakuco, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none
Patch	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2	none
Patch	none

Chris Rogers

Reported 2013-06-18 12:21:54 PDT

This is a simple name change of the class and the method (createWaveTable -> createPeriodicWave) See spec change for details: https://dvcs.w3.org/hg/audio/rev/7c4a40a9bb57

Attachments
Patch (72.33 KB, patch) 2013-06-18 17:48 PDT, Chris Rogers	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (529.94 KB, application/zip) 2013-06-18 21:03 PDT, Build Bot	no flags	Details
Patch (74.24 KB, patch) 2013-06-19 16:17 PDT, Chris Rogers	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (688.19 KB, application/zip) 2013-06-19 19:50 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (912.34 KB, application/zip) 2013-06-19 22:47 PDT, Build Bot	no flags	Details
Patch (74.83 KB, patch) 2013-06-20 11:49 PDT, Chris Rogers	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Chris Rogers

Comment 1 2013-06-18 12:22:35 PDT

Jer, I can do a patch here if you don't have time...

Chris Rogers

Comment 2 2013-06-18 17:48:08 PDT

Created attachment 204960 [details] Patch

Build Bot

Comment 3 2013-06-18 21:03:47 PDT

Comment on attachment 204960 [details] Patch Attachment 204960 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/951158 New failing tests: fast/js/global-constructors-attributes.html

Build Bot

Comment 4 2013-06-18 21:03:52 PDT

Created attachment 204968 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.3

Chris Rogers

Comment 5 2013-06-19 16:17:34 PDT

Created attachment 205040 [details] Patch

Build Bot

Comment 6 2013-06-19 19:50:14 PDT

Comment on attachment 205040 [details] Patch Attachment 205040 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/869564 New failing tests: fast/js/global-constructors-attributes.html

Build Bot

Comment 7 2013-06-19 19:50:17 PDT

Created attachment 205049 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.3

Build Bot

Comment 8 2013-06-19 22:47:54 PDT

Comment on attachment 205040 [details] Patch Attachment 205040 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/943413 New failing tests: fast/js/global-constructors-attributes.html

Build Bot

Comment 9 2013-06-19 22:47:58 PDT

Created attachment 205059 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3

Chris Rogers

Comment 10 2013-06-20 11:49:19 PDT

Created attachment 205106 [details] Patch

Chris Rogers

Comment 11 2013-06-23 21:47:25 PDT

Jer, this is a simple name change. Could you please review?

Jer Noble

Comment 12 2013-06-24 09:00:25 PDT

Comment on attachment 205106 [details] Patch Yep. r=me.

WebKit Commit Bot

Comment 13 2013-06-24 09:22:20 PDT

Comment on attachment 205106 [details] Patch Clearing flags on attachment: 205106 Committed r151914: <http://trac.webkit.org/changeset/151914>

WebKit Commit Bot

Comment 14 2013-06-24 09:22:24 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.