Add a test for resetting a textarea form control

• Component: Forms
• Status: RESOLVED FIXED

[Kirby White]

Resetting a form with an <input type="reset"> or <button type="reset"> control doesn't clear a <textarea>, nor set it to its default value if it has one.

[Kirby White]

Created attachment 11758 [details]
Test case

I can't assign this to myself, but I have a patch ready as soon as I make the unit test.

[Mark Rowe (bdash)]

Your test case already works correctly for me in both WebKit 418.9.1 and ToT.

[Kirby White]

Created attachment 11760 [details]
Unit test for resetting textarea controls

Sorry, I was using a flawed testcase, with a syntactic error that didn't carry over to the reduced one I posted.

Since I already have it, though, here's a test for the problem that turned out not to be a problem.  I've verified that this test works, and at the same time checked that no other tests catch the problem, by building a deliberately broken library.

I'd really like to make a PNG for this test, since the value of the textarea in JS might not match the value displayed on the page if it doesn't update properly.  But I can't find any information on how to do that.  Any pointers?

[Alexey Proskuryakov]

To create a pixel test, just remove the dumpAsText() call, and add a --pixel switch to run-webkit-tests when generating the results.

[Kirby White]

Created attachment 11762 [details]
Unit test including pixel test

Great, thanks!  Here's the full test.

[Mark Rowe (bdash)]

Landed in r18067.