Summary: | REGRESSION(r151632) : Build error on ASSERT(WTF_USE_GRAMMAR_CHECKING) | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | KyungTae Kim <ktf.kim> | ||||||||||
Component: | New Bugs | Assignee: | KyungTae Kim <ktf.kim> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | allan.jensen, andersca, benjamin, cdumez, cmarcelo, commit-queue, eflews.bot, g.czajkowski, gyuyoung.kim, gyuyoung.kim, jturcotte, svillar, webkit-ews | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 117585 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
KyungTae Kim
2013-06-17 02:12:04 PDT
Created attachment 204801 [details]
Patch
Could you fix the assert instead? Created attachment 204803 [details]
Patch
Comment on attachment 204803 [details] Patch Attachment 204803 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/858391 Comment on attachment 204803 [details] Patch Attachment 204803 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/849318 Comment on attachment 204803 [details] Patch Attachment 204803 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/907336 Comment on attachment 204803 [details] Patch Attachment 204803 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/939006 Created attachment 204804 [details]
Patch
(In reply to comment #8) > Created an attachment (id=204804) [details] > Patch Your approach seems better than mine, please check the ASSERT codes in the below, too: Source/WebCore/editing/Editor.cpp: In member function ‘void WebCore::Editor::markMisspellingsOrBadGrammar(const WebCore::VisibleSelection&, bool, WTF::RefPtr<WebCore::Range>&)’: Source/WebCore/editing/Editor.cpp:2067:9: error: ‘WTF_USE_GRAMMAR_CHECKING’ was not declared in this scope Source/WebCore/editing/Editor.cpp: In member function ‘void WebCore::Editor::markBadGrammar(const WebCore::VisibleSelection&)’: Source/WebCore/editing/Editor.cpp:2095:5: error: ‘WTF_USE_GRAMMAR_CHECKING’ was not declared in this scope I'm also getting errors in TextCheckingHelper.cpp I am sorry for the debug break :/ It seems that grammar checking needs more guards in WebCore. Do you mind if I revert the problematic patch? Thanks Created attachment 204809 [details]
Patch
Comment on attachment 204809 [details]
Patch
r=me
I wonder if a runtime check for the context menu would have been enough though.
Comment on attachment 204809 [details] Patch Clearing flags on attachment: 204809 Committed r151640: <http://trac.webkit.org/changeset/151640> All reviewed patches have been landed. Closing bug. |