Summary: | Web Inspector: Copying array or object output does not contain values | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||
Component: | Web Inspector | Assignee: | Antoine Quint <graouts> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Antoine Quint
2013-06-14 18:33:47 PDT
Created attachment 204753 [details]
Patch
Comment on attachment 204753 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204753&action=review > Source/WebInspectorUI/UserInterface/ConsoleCommandResult.js:50 > + get clipboarPrefixString () Typo. > Source/WebInspectorUI/UserInterface/ConsoleMessageImpl.js:659 > + get clipboarPrefixString () Typo. > Source/WebInspectorUI/UserInterface/LogContentView.js:267 > + var usePrefix = messages.length > 1; I explicitly removed this logic before. I think the prefix is always useful for row selection and Commad-S. We now support text range selection if you don't want the prefix. (In reply to comment #3) > (From update of attachment 204753 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204753&action=review > > > Source/WebInspectorUI/UserInterface/ConsoleCommandResult.js:50 > > + get clipboarPrefixString () > > Typo. > > > Source/WebInspectorUI/UserInterface/ConsoleMessageImpl.js:659 > > + get clipboarPrefixString () > > Typo. Heh, at least it's consistent. > > Source/WebInspectorUI/UserInterface/LogContentView.js:267 > > + var usePrefix = messages.length > 1; > > I explicitly removed this logic before. I think the prefix is always useful for row selection and Commad-S. We now support text range selection if you don't want the prefix. Maybe we should only drop the prefix for a single command result or prompt. I remember Joe was annoyed by it. Comment on attachment 204753 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204753&action=review >>> Source/WebInspectorUI/UserInterface/LogContentView.js:267 >>> + var usePrefix = messages.length > 1; >> >> I explicitly removed this logic before. I think the prefix is always useful for row selection and Commad-S. We now support text range selection if you don't want the prefix. > > Maybe we should only drop the prefix for a single command result or prompt. I remember Joe was annoyed by it. That would be fine for copy, but Command-S should always include all prefixes. (In reply to comment #5) > (From update of attachment 204753 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204753&action=review > > >>> Source/WebInspectorUI/UserInterface/LogContentView.js:267 > >>> + var usePrefix = messages.length > 1; > >> > >> I explicitly removed this logic before. I think the prefix is always useful for row selection and Commad-S. We now support text range selection if you don't want the prefix. > > > > Maybe we should only drop the prefix for a single command result or prompt. I remember Joe was annoyed by it. > > That would be fine for copy, but Command-S should always include all prefixes. Actually, upon further testing, the patch, as-is, does the right thing when saving the Console log via Cmd+S: all prefixes show up in the log. Could you re-review taking this into account? Created attachment 205004 [details]
Patch
Comment on attachment 205004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205004&action=review > Source/WebInspectorUI/UserInterface/ConsoleCommandResult.js:37 > + this.enforcesClipboardPrefixString = false; This could go on the prototype. > Source/WebInspectorUI/UserInterface/ConsoleMessageImpl.js:41 > + this.enforcesClipboardPrefixString = true; Ditto. Created attachment 205010 [details]
Patch for landing
Comment on attachment 205010 [details] Patch for landing Clearing flags on attachment: 205010 Committed r151738: <http://trac.webkit.org/changeset/151738> All reviewed patches have been landed. Closing bug. |