Bug 117666
Summary: | REGRESSION (r143299): Cannot edit text after clicking 'View source code' button on jWYSIWYG | ||
---|---|---|---|
Product: | WebKit | Reporter: | Andy Estes <aestes> |
Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW | ||
Severity: | Normal | CC: | ahmad.saleem792, karlcow, pmorse, rniwa, webkit-bug-importer |
Priority: | P2 | Keywords: | BlinkMergeCandidate, InRadar |
Version: | 528+ (Nightly build) | ||
Hardware: | All | ||
OS: | All | ||
URL: | http://akzhan.github.io/jwysiwyg/help/examples/02-full.html | ||
Bug Depends on: | 110172 | ||
Bug Blocks: |
Andy Estes
After <http://trac.webkit.org/changeset/143299>, you can no longer edit text on in source code mode on the jWYSIWYG editor.
This was first reported to the Chromium project: https://code.google.com/p/chromium/issues/detail?id=246738
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Andy Estes
<rdar://problem/14163133>
Alexey Proskuryakov
*** Bug 117888 has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
A fix was landed in Blink.
Andy Estes
(In reply to comment #3)
> A fix was landed in Blink.
Blink's fix was just to roll out r143299. I don't want to do that before taking the time to investigate the issue. We might be able to fix it without regressing webkit.org/b/110172.
Ryosuke Niwa
https://github.com/akzhan/jwysiwyg doesn't exist anymore.
Ryosuke Niwa
I guess the latest website is https://github.com/cmelbye/jwysiwyg
Ahmad Saleem
Chrome Commit was trying to modify DOMWindow.cpp and this bit:
https://github.com/WebKit/WebKit/blob/64f843f962fd4b62b95fb3c3c53127b6f526fbcd/Source/WebCore/page/DOMWindow.cpp#L1001
via this commit:
https://src.chromium.org/viewvc/blink?view=revision&revision=152395
While on Chrome Bug, it seems that the bug was back in Chrome 64 onward..
https://bugs.chromium.org/p/chromium/issues/detail?id=246738#c17
Do we want this fix? Thanks!
Karl Dubost
The project pointed by Ryosuke has not been updated for 14 years. I wonder if there are still people using it.
Or if there is a test case to reproduce the issue.