Summary: | [Windows] Provide simple <meter> drawing logic for testing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Brent Fulgham
2013-06-14 09:54:36 PDT
Created attachment 204717 [details]
Patch
Comment on attachment 204717 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204717&action=review > Source/WebCore/rendering/RenderThemeSafari.h:145 > + virtual IntSize meterSizeForBounds(const RenderMeter*, const IntRect&) const; > + virtual bool supportsMeter(ControlPart) const; > + virtual void adjustMeterStyle(StyleResolver*, RenderStyle*, Element*) const; > + virtual bool paintMeter(RenderObject*, const PaintInfo&, const IntRect&); No OVERRIDEs on these? > Source/WebCore/rendering/RenderThemeWin.cpp:140 > +// Progress bar parts > +#define PP_BAR 1 > +#define PP_BARVERT 2 > +#define PP_CHUNK 3 > +#define PP_CHUNKVERT 4 > +#define PP_FILL 5 > +#define PP_FILLVERT 6 > +#define PP_PULSEOVERLAY 7 > +#define PP_MOVEOVERLAY 8 > +#define PP_PULSEOVERLAYVERT 9 > +#define PP_MOVEOVERLAYVERT 10 > +#define PP_TRANSPARENTBAR 11 > +#define PP_TRANSPARENTBARVERT 12 > + > +// Progress bar states > +#define PBBS_NORMAL 1 > +#define PBBS_PARTIAL 2 > +#define PBBVS_NORMAL 1 // Vertical > +#define PBBVS_PARTIAL 2 > + > +// Progress bar fill states > +#define PBFS_NORMAL 1 > +#define PBFS_ERROR 2 > +#define PBFS_PAUSED 3 > +#define PBFS_PARTIAL 4 > +#define PBFVS_NORMAL 1 // Vertical > +#define PBFVS_ERROR 2 > +#define PBFVS_PAUSED 3 > +#define PBFVS_PARTIAL 4 I'd use enums for these, but #defines are fine (especially if they come from Windows headers). (In reply to comment #2) > > + virtual bool paintMeter(RenderObject*, const PaintInfo&, const IntRect&); > > No OVERRIDEs on these? Good point. I'll fix when I land. > > +#define PBFVS_PARTIAL 4 > > I'd use enums for these, but #defines are fine (especially if they come from Windows headers). Yeah -- I was trying to be consistent with the other examples in this file. Committed r151601: <http://trac.webkit.org/changeset/151601> |