Bug 117638

Summary: [GTK] Let F5 refresh the page in MiniBrowser
Product: WebKit Reporter: Morten Stenshorne <mstensho>
Component: WebKitGTKAssignee: Morten Stenshorne <mstensho>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Morten Stenshorne
Reported 2013-06-14 05:52:26 PDT
Useful when playing with test cases and you want to reload conveniently and quickly. :)
Attachments
Patch (2.27 KB, patch)
2013-06-14 05:57 PDT, Morten Stenshorne 		no flags
DetailsFormatted DiffDiff
Patch (2.30 KB, patch)
2013-07-02 06:46 PDT, Morten Stenshorne 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Morten Stenshorne
Comment 1 2013-06-14 05:57:33 PDT
Created attachment 204707 [details] Patch
Alberto Garcia
Comment 2 2013-07-02 05:24:14 PDT
Looks good to me. Maybe we could have both the load and reload icons? Anyway it's weird that we were using the wrong icon there :)
Morten Stenshorne
Comment 3 2013-07-02 05:29:31 PDT
Do you want me to add another button with the load icon (which actually performs a load action rather than reloading)? What's that for anyway? For those with trouble finding the Enter key? :) Touch UI?
Alberto Garcia
Comment 4 2013-07-02 05:46:07 PDT
Yeah, I don't know, if no one missed it in all this time I guess it's not so important :)
Carlos Garcia Campos
Comment 5 2013-07-02 06:08:32 PDT
Comment on attachment 204707 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204707&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:528 > + GtkAccelGroup *accelGroup = gtk_accel_group_new(); > + gtk_window_add_accel_group(GTK_WINDOW(window), accelGroup); gtk_window_add_accel_group takes a reference of the accel group, so you need to call g_object_unref().
Morten Stenshorne
Comment 6 2013-07-02 06:46:22 PDT
Created attachment 205905 [details] Patch
Carlos Garcia Campos
Comment 7 2013-07-02 11:01:02 PDT
Comment on attachment 205905 [details] Patch LGTM
WebKit Commit Bot
Comment 8 2013-07-03 00:31:09 PDT
Comment on attachment 205905 [details] Patch Clearing flags on attachment: 205905 Committed r152341: <http://trac.webkit.org/changeset/152341>
WebKit Commit Bot
Comment 9 2013-07-03 00:31:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.