|Summary:||[GTK] Let F5 refresh the page in MiniBrowser|
|Product:||WebKit||Reporter:||Morten Stenshorne <mstensho>|
|Component:||WebKitGTK||Assignee:||Morten Stenshorne <mstensho>|
|Severity:||Normal||CC:||berto, cgarcia, commit-queue|
|Version:||528+ (Nightly build)|
Description Morten Stenshorne 2013-06-14 05:52:26 PDT
Comment 1 Morten Stenshorne 2013-06-14 05:57:33 PDT
Created attachment 204707 [details] Patch
Comment 2 Alberto Garcia 2013-07-02 05:24:14 PDT
Looks good to me. Maybe we could have both the load and reload icons? Anyway it's weird that we were using the wrong icon there :)
Comment 3 Morten Stenshorne 2013-07-02 05:29:31 PDT
Do you want me to add another button with the load icon (which actually performs a load action rather than reloading)? What's that for anyway? For those with trouble finding the Enter key? :) Touch UI?
Comment 4 Alberto Garcia 2013-07-02 05:46:07 PDT
Yeah, I don't know, if no one missed it in all this time I guess it's not so important :)
Comment 5 Carlos Garcia Campos 2013-07-02 06:08:32 PDT
Comment on attachment 204707 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204707&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:528 > + GtkAccelGroup *accelGroup = gtk_accel_group_new(); > + gtk_window_add_accel_group(GTK_WINDOW(window), accelGroup); gtk_window_add_accel_group takes a reference of the accel group, so you need to call g_object_unref().
Comment 6 Morten Stenshorne 2013-07-02 06:46:22 PDT
Created attachment 205905 [details] Patch
Comment 7 Carlos Garcia Campos 2013-07-02 11:01:02 PDT
Comment on attachment 205905 [details] Patch LGTM
Comment 8 WebKit Commit Bot 2013-07-03 00:31:09 PDT
Comment on attachment 205905 [details] Patch Clearing flags on attachment: 205905 Committed r152341: <http://trac.webkit.org/changeset/152341>
Comment 9 WebKit Commit Bot 2013-07-03 00:31:12 PDT
All reviewed patches have been landed. Closing bug.