Bug 117579 – [WebAudio] Remove the "alternate" API names from WebAudio interfaces.

• Component: WebCore Misc.
• Status: NEW

[Jer Noble]

During the development of the WebAudio spec, certain APIs were renamed. In an effort to keep from breaking existing sites, the original API names were left in as aliases.  However, it has been argued that these "alternate" API names should be normative in the spec because of their continued support in WebKit. Dropping these "alternate" names would strengthen the counter-argument of removing these "alternate" names from the spec.

To be removed:

AudioBufferSourceNode
- noteOn
- noteGrainOn
- noteOff

AudioContext
- createGainNode
- createDelayNode
- createJavaScriptNode

OscillatorNode
- noteOn
- noteOff

AudioParam
- setTargetValueAtTime

[Radar WebKit Bug Importer]

<rdar://problem/14144796>

[Jer Noble]

Created attachment 204643 [details]
Patch

[Ehsan Akhgari [:ehsan]]

Is this patch enough?  There are tons of WebKit tests which use these alternate names...

[Jer Noble]

Yes, I'm working on the tests now.

[Build Bot]

Comment on attachment 204643 [details]
Patch

Attachment 204643 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/851229

New failing tests:
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
webaudio/biquad-lowshelf.html
webaudio/audiobuffersource-playbackrate.html
webaudio/biquad-highshelf.html
webaudio/biquad-bandpass.html
webaudio/biquad-allpass.html
http/tests/inspector/inspect-element.html
webaudio/automatic-pull-node.html
webaudio/audiochannelmerger-stereo.html
webaudio/audiochannelsplitter.html
webaudio/audiobuffersource-multi-channels.html
webaudio/audioparam-exponentialRampToValueAtTime.html
webaudio/audioparam-summingjunction.html
editing/pasteboard/copy-image-with-alt-text.html
webaudio/audionode.html
webaudio/audioparam-connect-audioratesignal.html
editing/pasteboard/smart-paste-001.html
webaudio/audioparam-setValueAtTime.html
webaudio/audionode-connect-order.html
webaudio/biquad-lowpass.html
webaudio/biquad-highpass.html
webaudio/audioparam-linearRampToValueAtTime.html
webaudio/audiobuffersource-playbackState.html
webaudio/audiobuffersource-loop-points.html
webaudio/audioparam-setTargetAtTime.html
webaudio/audioparam-setValueCurveAtTime.html

[Build Bot]

Created attachment 204670 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Brady Eidson]

Comment on attachment 204643 [details]
Patch

Assuming that patches for review since 2013 are stale, r-

[jonobr1]

In addition and related to the issue stated above, based on the latest drafts: https://webaudio.github.io/web-audio-api/#widl-AudioBufferSourceNode-start-void-double-when-double-offset-double-duration the new method name on an AudioBufferSourceNode `start` takes additional parameters to what the `noteOn` method takes. Specifically offset and duration parameters. As a web developer I'm not biased on whether to keep the alias' or not, but I would like to use this functionality.

Should I open a new issue to request this functionality?

[Eric Carlson]

(In reply to comment #8)
> In addition and related to the issue stated above, based on the latest
> drafts:
> https://webaudio.github.io/web-audio-api/#widl-AudioBufferSourceNode-start-
> void-double-when-double-offset-double-duration the new method name on an
> AudioBufferSourceNode `start` takes additional parameters to what the
> `noteOn` method takes. Specifically offset and duration parameters. As a web
> developer I'm not biased on whether to keep the alias' or not, but I would
> like to use this functionality.
> 
> Should I open a new issue to request this functionality?

That is unrelated to this bug, so please file a new report.